Skip to content

implement graphql-inspector#478

Open
Cold-A-Muse wants to merge 1 commit intodevfrom
feat/graphql-inspector
Open

implement graphql-inspector#478
Cold-A-Muse wants to merge 1 commit intodevfrom
feat/graphql-inspector

Conversation

@Cold-A-Muse
Copy link
Collaborator

FIXES HAAS-445

@linear
Copy link

linear bot commented Oct 3, 2022

HAAS-445 GraphQL Auditor

Description

The GraphQL Inspector is a potential strong ally for use to keep a check on the resilience of our API (mostly its security). It would be good to investigate the Inspector, and see what types of data it can generate.

  • What can we extract from this Auditor?
  • Are there things we can do to add this to our CI process @JMitnik ?

@Cold-A-Muse Cold-A-Muse requested a review from JMitnik October 3, 2022 06:21
@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-478.d2j37lx5gsfgp1.amplifyapp.com

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-478.d36c61y3h9mqcx.amplifyapp.com

@JMitnik
Copy link
Owner

JMitnik commented Oct 3, 2022

  • Does this work for all GraphQL files in client / dashboard atm?
  • Do you know what the numbers mean already?
  • Any particular number we should use as "threshold"?

@Cold-A-Muse
Copy link
Collaborator Author

Cold-A-Muse commented Oct 3, 2022

  • Does this work for all GraphQL files in client / dashboard atm?

yes I use the blobs strings found in graphql-codegen files for both client and dashboard

  • Do you know what the numbers mean already?

Depth: How many layers in your graphql query
Aliases: N/A
Directives: N/A
Token count: Amount of grouped characters in your request (https://www.envelop.dev/docs/guides/securing-your-graphql-api#reject-malicious-operation-documents)
Complexity Score: just some cost analysis algorithm that indicates how likely there will be resource overload. (think it is mentioned here https://github.com/Escape-Technologies/graphql-armor#cost-limit)

  • Any particular number we should use as "threshold"?

Anything a little bit above our current largest query i suppose
Depth GetWorkspaceSessions: 13 so like 15? (unless we want to make this query simpler one way or another)
Token count GetDialogueStatistics: 212 so like 250?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants