Skip to content

Update to Babel 6; Change named exports style to workaround Babel bug T7048#188

Open
UltCombo wants to merge 1 commit intomasterfrom
babel-6
Open

Update to Babel 6; Change named exports style to workaround Babel bug T7048#188
UltCombo wants to merge 1 commit intomasterfrom
babel-6

Conversation

@UltCombo
Copy link
Member

Babel currently has a bug concerning exporting/hoisting async function declarations: https://phabricator.babeljs.io/T7048
I've changed the remaining named exports' style as well for consistency.

Needs review/testing.

… T7048

Babel currently has a bug concerning exporting/hoisting async function declarations: https://phabricator.babeljs.io/T7048
I've changed the remaining named exports' style as well for consistency.
@UltCombo
Copy link
Member Author

Babel 6's async arrow functions with default/rest parameters are broken: https://phabricator.babeljs.io/T3077#73064
This breaks a good part of our code base (harmonic run, harmonic config).

On a side note, we need to get 100% test coverage soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant