fix: propagate error events in AgentRunner.run()#103
Merged
JackChen-me merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
run() only handled 'done' events from stream(), silently dropping 'error' events. This caused failed LLM calls to return an empty RunResult that the caller treated as successful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentRunner.run()only handled'done'events fromstream(), silently dropping'error'events. Failed LLM calls returned an emptyRunResultthatAgent.executeRun()treated assuccess: true.run()re-throws the error, whichexecuteRun()catches and converts tosuccess: falsewith the error message inoutput.Closes #98
Test plan
tests/runner-error-propagation.test.tscovering 3 scenarios:success: falseinAgentRunResultAgentRunner.run()throws when adapter errorserrorstate on LLM failure