fix: propagate AbortSignal through tools, Gemini adapter, and abort queue path#104
Merged
JackChen-me merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
…d abort queue path (#99, #100, #101) - #99: pass per-call effectiveAbortSignal to buildToolContext() so tools receive the correct signal instead of the static runner-level one - #100: replace manual pending-task loop with queue.skipRemaining() on abort, fixing blocked tasks left non-terminal and missing events - #101: forward abortSignal in Gemini adapter's buildConfig() so the SDK can cancel in-flight API calls - Add 8 targeted tests for all three fixes
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three AbortSignal propagation gaps in the cancellation chain:
buildToolContext()now receives the per-calleffectiveAbortSignalinstead of the staticthis.options.abortSignal, so in-flight tool executions (bash, file_write, etc.) respect orchestrator cancellationexecuteQueuenow callsqueue.skipRemaining()instead of a manual loop over pending tasks, fixing: blocked tasks left non-terminal, missingtask:skippedevents, andall:completenever firingbuildConfig()forwardsabortSignalto the SDK'sGenerateContentConfig, enabling cancellation of in-flight Gemini API callsChanges
src/agent/runner.tsbuildToolContext(abortSignal?)accepts and passes through the effective signalsrc/orchestrator/orchestrator.tsqueue.skipRemaining()src/llm/gemini.tsbuildConfig()includesabortSignalin configtests/abort-signal-propagation.test.tsTest plan
task:skippedevents emitted,all:completefireschat()andstream()passabortSignalin config, omit when not providedCloses #99, closes #100, closes #101