Skip to content

fix(release-please): handle label-race gracefully with error guard #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobPEvans wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

fix(release-please): handle label-race gracefully with error guard #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54bef2b
fix(release-please): tolerate label-application race with continue-on…
JacobPEvans Apr 27, 2026
aeeeb2f
fix(release-please): re-fail on genuine errors when no PR is found
JacobPEvans Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/_release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,15 @@ jobs:
permission-pull-requests: write
permission-issues: write

# `continue-on-error` tolerates the upstream label-application race:
# release-please-action opens the PR successfully, then immediately tries
# to apply `autorelease: pending` via GraphQL — but the PR's global node ID
# hasn't propagated yet, so GitHub returns "Could not resolve to a node".
# The PR is still created and the downstream `Find release PR number` step
# discovers it via REST, so a label-only failure should not fail the job.
- uses: googleapis/release-please-action@v5
id: release
continue-on-error: true
Comment thread
JacobPEvans marked this conversation as resolved.
with:
token: ${{ steps.app-token.outputs.token }}
manifest-file: .release-please-manifest.json
Expand All @@ -89,6 +96,12 @@ jobs:
PR_NUMBER=$(gh pr list --head "release-please--branches--${BASE_BRANCH}" --json number --jq '.[0].number // empty')
echo "number=$PR_NUMBER" >> "$GITHUB_OUTPUT"

- name: Re-fail on genuine release-please error
if: "!cancelled() && steps.release.outcome == 'failure' && steps.find-pr.outputs.number == ''"
run: |
echo "::error::release-please-action failed and no release PR was found via REST. This is a genuine failure (auth/config/API error), not a transient label-application race."
exit 1

# Disable+re-enable handles RC3 (stale auto-merge queue: PR is CLEAN with
# auto-merge enabled but GitHub never executes the merge). The retry loop
# handles RC2 (transient GraphQL errors from `gh pr merge --auto`).
Expand Down
Loading