feat(shared): host repo-health-audit shared config in ai-workflows#191
Open
JacobPEvans wants to merge 2 commits intomainfrom
Open
feat(shared): host repo-health-audit shared config in ai-workflows#191JacobPEvans wants to merge 2 commits intomainfrom
JacobPEvans wants to merge 2 commits intomainfrom
Conversation
Mirrors JacobPEvans/.github/.github/workflows/shared/repo-health-audit-*.md.
Hosting these in ai-workflows works around a gh-aw bug where computeImportRelPath
uses LastIndex("/.github/") on the runtime-import macro path, which picks the
wrong slash position when the source repo is named '.github' (causing
ERR_SYSTEM: Runtime import file not found in every consumer's Repo Health Audit run).
Source repos that are NOT named '.github' avoid the bug; ai-workflows is a
natural home for shared AI workflow content.
Upstream bug: filing follow-up at githubnext/gh-aw.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
This PR adds shared Repo Health Audit configuration and prompt content to ai-workflows so consumer repos can import them from a repository not named .github, avoiding a known gh aw import path collision.
Changes:
- Added a shared health-audit prompt document describing the audit procedure and issue/sub-issue structure.
- Added a shared config document defining
toolsandsafe-outputsconstraints for the audit workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/shared/repo-health-audit-prompt.md | New shared prompt text for the Repo Health Audit agent. |
| .github/workflows/shared/repo-health-audit-config.md | New shared YAML front matter for tools + safe-outputs used by the audit. |
- L17: replace ambiguous "Labels: ..." with explicit two-step flow (`create-issue` auto-applies `ai:created`; agent invokes `add-labels` for `type:chore`, `priority:low`, `size:xs`). Matches the `safe-outputs.add-labels.allowed` set in the shared config. - L103: replace blanket 25-hour staleness window with cron-aware windows. Daily-or-more-frequent flags after 25h; weekly after 8d; monthly skipped. Eliminates false positives on weekly/monthly schedules. Addresses copilot review threads on #191.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hosts
repo-health-audit-config.mdandrepo-health-audit-prompt.mdinai-workflowsso consumer repos can import them without tripping agh-awimport-path bug specific to
.github-named source repos.Why move from
.github?gh aw'scomputeImportRelPath(
pkg/parser/import_field_extractor.go) usesstrings.LastIndex("/.github/")to derive the runtime-import macro path.When the source repo is itself named
.github, the runner's cache pathcontains TWO
/.github/segments (the workspace's.githubfolder andthe source repo name) and
LastIndexpicks the wrong one, producing amacro that points at a path the runtime cannot find:
This caused every Repo Health Audit run to fail across all 7 consumer
repos for as long as the workflow existed (15+ failures, 0 successes per
consumer at last count).
Moving the shared content to a repo NOT named
.githubavoids thecollision. Verified end-to-end on
ansible-proxmox(test branchimports from
feat/shared-health-audit; full pipeline activation →agent → detection → safe_outputs → conclusion all succeeded).
Changes
.github/workflows/shared/repo-health-audit-config.md(new): mirrorsthe config from
JacobPEvans/.github(tools, safe-outputs:create-issue / add-labels / close-issue).
.github/workflows/shared/repo-health-audit-prompt.md(new):mirrors the audit prompt with two refinements vs the original to
address review feedback:
create-issueauto-appliesai:created, agent invokesadd-labelsfor the rest.25h window, weekly → 8d, monthly → skipped.
Test Plan
ansible-proxmoxtest run from this branch (already verified —run 24994312039 all 5 jobs success)
imports:change to the other 6consumers, run
gh-aw-pin-refresh, confirm next scheduled healthaudit succeeds
JacobPEvans/.github/.github/workflows/shared/once all consumersare migrated
Migration plan (post-merge)
.github/workflows/repo-health-audit.mdtoimport from
JacobPEvans/ai-workflows/.github/workflows/shared/repo-health-audit-config.md@main(and the prompt likewise).
gh-aw-pin-refresh.ymlon each consumer to regenerate thelockfile.
JacobPEvans/.github/.github/workflows/shared/can be deleted.Affected consumers:
ansible-proxmox,ansible-proxmox-apps,ansible-splunk,orbstack-kubernetes,nix-darwin,nix-home,nix-ai.Upstream
Filing a bug at
githubnext/gh-awso this workaround can be retiredonce
computeImportRelPathanchors on/.github/aw/imports/insteadof any
/.github/segment. Bug report drafted at/tmp/gh-aw-upstream-bug-report.md.Related: #185