chore(git-standards): forbid emoji in commits and PR titles#266
Merged
JacobPEvans merged 2 commits intomainfrom Apr 29, 2026
Merged
chore(git-standards): forbid emoji in commits and PR titles#266JacobPEvans merged 2 commits intomainfrom
JacobPEvans merged 2 commits intomainfrom
Conversation
Adds an explicit "Commit & PR Title Style" section to the pr-standards skill (loaded on demand whenever an agent drafts a PR), and a one-line cross-reference bullet in git-workflow-standards. Companion to the soul.md flip in ai-assistant-instructions. Together these eliminate the gap that caused recent automated AI-fix PRs (#263, #257) to land with `🤖` prefixes — soul.md was endorsing gitmoji and neither plugin skill said otherwise. Applies to human, AI-assisted, and bot-authored PRs alike. Conventional- commit prefixes carry the signal. (claude)
There was a problem hiding this comment.
Pull request overview
Adds explicit guidance in the git-standards skills to forbid emoji/gitmoji in commit messages and PR metadata, aligning PR drafting behavior with the repo’s conventional-commit style expectations.
Changes:
- Add a new “Commit & PR Title Style” section to
pr-standardsthat bans emoji/gitmoji and calls for conventional-commit prefixes. - Add a cross-reference bullet in
git-workflow-standardsreinforcing conventional-commit prefixes and no-emoji commit messages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
git-standards/skills/pr-standards/SKILL.md |
Introduces explicit no-emoji guidance for commits/PR titles (and currently PR descriptions) plus conventional-commit prefix guidance. |
git-standards/skills/git-workflow-standards/SKILL.md |
Adds a branch-hygiene bullet that cross-references pr-standards for commit-message style (no emoji + conventional-commit prefixes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…hrasing Addresses copilot review feedback (threads VOoy, VOpG, VOpT) on PR #266. Changes: - Rename section header from "Commit & PR Title Style" to "Commit, PR Title & PR Description Style" (header now matches body scope) - Split rule into two parts: emoji ban (commits + titles + descriptions + release notes) and conventional-commit prefix requirement (commit subjects + PR titles only) - Replace ambiguous "Use conventional-commit prefixes only" with "are required at the start of commit subjects and PR titles only" — the original "only" was meant to scope where prefixes apply, but read as if the prefix should be the entire message - Add release notes to the ban for parity with the soul.md update in ai-assistant-instructions PR #604 (claude)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the git workflow and PR standards to mandate conventional-commit prefixes and prohibit the use of emojis in commit messages and PR titles. A review comment suggests refining the language in the PR standards document to improve clarity for automated tools, specifically replacing idiomatic phrasing with more direct language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## Commit & PR Title Stylesection togit-standards/skills/pr-standards/SKILL.mdgit-standards/skills/git-workflow-standards/SKILL.mdProblem
Companion to JacobPEvans/ai-assistant-instructions PR #604 (linked below). Until now, neither plugin skill said anything about emoji in commits/PRs, while ai-assistant-instructions'
soul.mdactively encouraged gitmoji. Result: recent automated AI-fix PRs (#257 `🤖 Fix #256: stale guard test fixtures...`, #263 `🤖 Fix #261: make _is_on_main_branch() mockable...`) landed with🤖prefixes.This PR closes the loop on the plugin side so that whenever an agent loads
/pr-standards(the skill that fires precisely when drafting a PR), it sees the no-emoji rule explicitly.Why both repos
soul.mdflip alone could be missed by a session that doesn't auto-load it (rare, but possible)pr-standardsis loaded on demand at the moment of PR creation — perfect last-line-of-defensegit-workflow-standardscross-reference catches commit-message authors who didn't loadpr-standardsScope
Test plan
Related
(claude)