add support for two step authentication#1
Open
swiftster wants to merge 2 commits intoJaffa:masterfrom
Open
Conversation
Jaffa
reviewed
May 25, 2018
Owner
Jaffa
left a comment
Jaffa
left a comment
There was a problem hiding this comment.
Thanks for this - and sorry for the delay in getting to it (the GitHub notification got buried, but that's no excuse)!
|
|
||
| if r.history and r.history[-1].is_redirect and AMAZON_MFA in r.history[-1].headers['Location']: | ||
| soup = BeautifulSoup(r.content, "html.parser") | ||
| query = {"otpCode": input("2FA Code:")} |
Owner
There was a problem hiding this comment.
Given the library may be used through an app, or a voice interface, I think this will need to be pulled into an optional callout when constructing the AmazonMusic object.
There was a problem hiding this comment.
Yes i think so too.
A better solution is to provide a callback like this:
from amazonmusic import AmazonMusic
am = AmazonMusic()
@am.two_factor
def two_factor(authorize):
code = input('2FA Code: ')
authorize(code)
|
@swiftster please check my suggestion. |
|
This would be nice to have :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authentication currently breaks if user has two-step authentication enabled (like i do). This detects if user was redirected to the /ap/mfa page and prompts user for a 2FA code.