This repository was archived by the owner on Sep 10, 2020. It is now read-only.
Enable two static shortcuts: record and overlay.#139
Open
JakeWharton wants to merge 4 commits intomasterfrom
Open
Enable two static shortcuts: record and overlay.#139JakeWharton wants to merge 4 commits intomasterfrom
JakeWharton wants to merge 4 commits intomasterfrom
Conversation
JakeWharton
force-pushed
the
SimonMarquis-feature/static_shortcuts
branch
from
9f80498 to
740fb76
Compare
| </shortcut> | ||
| <shortcut | ||
| android:enabled="true" | ||
| android:icon="@drawable/ic_shortcut_record" |
Contributor
There was a problem hiding this comment.
You renamed this file to ic_shortcut_record_48dp (hence build fail)
| > | ||
| <shortcut | ||
| android:enabled="true" | ||
| android:icon="@drawable/ic_shortcut_overlay" |
Contributor
There was a problem hiding this comment.
You renamed this file to ic_shortcut_overlay_48dp (hence build fail)
SimonMarquis
suggested changes
Dec 10, 2016
Contributor
SimonMarquis
left a comment
SimonMarquis
left a comment
There was a problem hiding this comment.
You renamed these two files that are referenced in shortcut.xml
- ic_shortcut_overlay_48dp
- ic_shortcut_record_48dp
Owner
Author
|
This needs debug/ and release/ variants since the targetPackage will be wrong for one of the two and the use of |
…_shortcuts Continues #139 Enable two static shortcuts: record and overlay.
Contributor
|
If you really want pixel perfect images for these two shortcut, using Roman Nurik's awsome Android Asset Studio: |
Contributor
NightlyNexus
left a comment
NightlyNexus
left a comment
There was a problem hiding this comment.
Any interest in this? Or, would you be interested in reviewing an updated PR?
understandable if neither.
| android:theme="@style/Theme.Telecine.Transparent" | ||
| android:excludeFromRecents="true" | ||
| android:taskAffinity="" | ||
| android:enabled="@bool/widget_shortcut_enabled" |
| String ACTION_QUICK_TILE_LAUNCHED = "Quick Tile Launched"; | ||
| String ACTION_QUICK_TILE_REMOVED = "Quick Tile Removed"; | ||
| String ACTION_STATIC_SHORTCUT_RECORD = "Static Shortcut Record"; | ||
| String ACTION_STATIC_SHORTCUT_OVERLAY = "Static Shortcut Overlay"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135. Closes #132.