This repository was archived by the owner on Sep 10, 2020. It is now read-only.
Fix issue #166 Crash on start on device below Android Api 24.#171
Closed
TonyTangAndroid wants to merge 1 commit intoJakeWharton:masterfrom
Closed
Fix issue #166 Crash on start on device below Android Api 24.#171TonyTangAndroid wants to merge 1 commit intoJakeWharton:masterfrom
TonyTangAndroid wants to merge 1 commit intoJakeWharton:masterfrom
Conversation
NightlyNexus
reviewed
Feb 9, 2018
Contributor
NightlyNexus
left a comment
NightlyNexus
left a comment
There was a problem hiding this comment.
thanks for following this and posting here.
|
|
||
| @Override public void onCreate() { | ||
| AndroidInjection.inject(this); | ||
| ((TelecineApplication) getApplication()).telecineComponent().api24OrGreaterServiceComponent().injector().inject(this); |
Contributor
There was a problem hiding this comment.
this is unfortunate. mind if i try something to see if we can avoid the Service knowing about its injector?
Contributor
There was a problem hiding this comment.
opened #172 to keep the usefulness of the Android injection pieces.
Author
There was a problem hiding this comment.
Cool. I got you the point. And your solution is much cleaner. I have also changed the implementation in my own project. Thank you for the help.
Contributor
There was a problem hiding this comment.
Thank you for looking into it! This was a fun problem.
Author
|
This pull request is closed in honor of a better implementation #172. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #166