Added a screenshot mode.

[tylerjroach]

I've added a screenshot button in the OverlayView. Rather than splitting Telecine into two different modes (recording vs. screenshot), I thought the two would fit together in the overlay. This way, the settings don't become more complex and a separate screenshot widget isn't needed. I added a FlashView in a quick attempt to animate the screenshot action and give the user visual feedback to the button press. When the screenshot has been taken, the overlay will reappear and allow the user to take another screenshot or a recording.

Potential Improvements:
*In attempting to keep the previous code mostly unchanged, I created a few screenshot methods that could probably be merged into the recording ones, ex. showNotification.
*Each notification currently overwrites the previous one. These notifications could be separated out, or a single notification could read something like... "2 screenshots taken".
*I added 2 strings that don't have translations.

Let me know what you think!

[JakeWharton]

Going to look soon. Sorry for the delay, lots going on in other projects.

On Fri, Oct 2, 2015 at 10:29 AM Tyler Roach notifications@github.com
wrote:

I've added a screenshot button in the OverlayView. Rather than splitting
Telecine into two different modes (recording vs. screenshot), I thought the
two would fit together in the overlay. This way, the settings don't become
more complex and a separate screenshot widget isn't needed. I added a
FlashView in a quick attempt to animate the screenshot action and give the
user visual feedback to the button press. When the screenshot has been
taken, the overlay will reappear and allow the user to take another
screenshot or a recording.

Potential Improvements:
*In attempting to keep the previous code mostly unchanged, I created a few
screenshot methods that could probably be merged into the recording ones,
ex. showNotification.
*Each notification currently overwrites the previous one. These
notifications could be separated out, or a single notification could read
something like... "2 screenshots taken".

Let me know what you think!

You can view, comment on, or merge this pull request online at:

#77
Commit Summary

• Added a screenshot mode.

File Changes

• M telecine/src/main/java/com/jakewharton/telecine/Analytics.java
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-0 (2)
• A telecine/src/main/java/com/jakewharton/telecine/FlashView.java
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-1 (68)
• M telecine/src/main/java/com/jakewharton/telecine/OverlayView.java
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-2 (9)
• M
  telecine/src/main/java/com/jakewharton/telecine/RecordingSession.java
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-3 (271)
• M
  telecine/src/main/java/com/jakewharton/telecine/TelecineService.java
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-4 (4)
• A telecine/src/main/res/drawable-hdpi/ic_camera_alt_white_24dp.png
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-5 (0)
• A telecine/src/main/res/drawable-mdpi/ic_camera_alt_white_24dp.png
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-6 (0)
• A telecine/src/main/res/drawable-xhdpi/ic_camera_alt_white_24dp.png
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-7 (0)
• A
  telecine/src/main/res/drawable-xxhdpi/ic_camera_alt_white_24dp.png
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-8 (0)
• A
  telecine/src/main/res/drawable-xxxhdpi/ic_camera_alt_white_24dp.png
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-9 (0)
• A telecine/src/main/res/drawable/screenshot_background.xml
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-10 (5)
• A telecine/src/main/res/layout/flash_view.xml
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-11 (6)
• M telecine/src/main/res/layout/overlay_view.xml
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-12 (9)
• M telecine/src/main/res/values/dimens.xml
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-13 (2)
• M telecine/src/main/res/values/strings.xml
  https://github.com/JakeWharton/Telecine/pull/77/files#diff-14 (2)

Patch Links:

• https://github.com/JakeWharton/Telecine/pull/77.patch
• https://github.com/JakeWharton/Telecine/pull/77.diff

—
Reply to this email directly or view it on GitHub
#77.

[tylerjroach]

No rush at all. Let me know if all of the formatting fix commits bother you and I could clean it up and submit a new pull request. I didn't have the proper indention settings before working on the project and noticed a few formatting issues after trying to clean it up at the end.

[simontb]

Shouldn't this be named imagefileFormat? Or picturefileFormat to follow the naming for the File in line 92.