authentication components #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sign in and sign up page
James-Cheaper
requested review from
James-Cheaper,
Urbanmisfit90,
forz-man,
gmanhas12 and
johnnvij
| ); | ||
| }; | ||
|
|
||
| const SignUp = ({ onSwitchToSignIn }) => { |
Owner
There was a problem hiding this comment.
can you make this a different file within the folder Auth
Collaborator
|
Consider enhancing error handling and adding detailed form validation. Implementing unit tests would help ensure long-term reliability |
Collaborator
Urbanmisfit90
left a comment
Urbanmisfit90
left a comment
There was a problem hiding this comment.
Looks pretty standard I'll look into modifying the tests to sync with it to resolve the ones that are failing.
forz-man
approved these changes
Jul 29, 2025
Urbanmisfit90
approved these changes
Jul 29, 2025
Collaborator
Urbanmisfit90
left a comment
Urbanmisfit90
left a comment
There was a problem hiding this comment.
Will cross these changes with what I currently have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sign in and sign up page