Skip to content

Conversation

@smorimoto
Copy link
Collaborator

No description provided.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto marked this pull request as ready for review May 27, 2025 04:12
@smorimoto smorimoto requested review from JamesBrill and Copilot May 27, 2025 04:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the vendored Corti test helper and switches to the official corti package, updating mocks and imports accordingly.

  • Import SpeechRecognition from corti rather than a local vendor file
  • Replace ../tests/vendor/corti.js and RecognitionManager imports with the new package
  • Update vi.mock calls and test setup to use the corti package and hoisted mock functions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

File Description
src/isAndroid.test.js Removed describe wrapper and streamlined imports for top-level Vitest hooks
src/android.test.js Dropped vendor import, added corti package import, updated mocks, moved lifecycle calls to root
src/SpeechRecognition.test.js Replaced local Corti import with corti package, hoisted browserSupportsPolyfills mock, removed vendor references
package.json Added corti dependency and bumped Vitest and coverage-v8 versions
Comments suppressed due to low confidence (1)

src/SpeechRecognition.test.js:265

  • A large block of tests related to transcript and continuous listening behaviors was removed; ensure critical scenarios (e.g., interim transcripts, command callbacks) are still covered by other tests to avoid regressions.
test("can set language", async () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants