Use fixed resume PDF and custom resume page title from navbar button#23
Open
JamesDeRaja wants to merge 1 commit intomainfrom
Open
Use fixed resume PDF and custom resume page title from navbar button#23JamesDeRaja wants to merge 1 commit intomainfrom
JamesDeRaja wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
fileandtitlequery parameter (/resume/viewer.html?file=JamesDeRaja_Resume.pdf&title=James_De_Raja_Unity_XR_Performance_Engineer_Resume) insrc/components/Navbar.tsx.public/resume/viewer.htmlto read an optionaltitlequery parameter and setdocument.titleto that value, falling back to the filename-derived title whentitleis not provided.fileagainstallowedFilesand defaults toJamesDeRaja_Resume.pdfif an invalid value is passed.Testing
npm run buildand the build completed successfully.Codex Task