Skip to content

Use fixed resume PDF and custom resume page title from navbar button#23

Open
JamesDeRaja wants to merge 1 commit intomainfrom
codex/open-resume-pdf-on-button-click
Open

Use fixed resume PDF and custom resume page title from navbar button#23
JamesDeRaja wants to merge 1 commit intomainfrom
codex/open-resume-pdf-on-button-click

Conversation

@JamesDeRaja
Copy link
Copy Markdown
Owner

Motivation

  • The top-right "View Resume (PDF)" button should open the existing fixed PDF instead of generating one and the resume viewer page should show a specific title when opened from the navbar.

Description

  • Updated the navbar button to open the viewer with an explicit file and title query parameter (/resume/viewer.html?file=JamesDeRaja_Resume.pdf&title=James_De_Raja_Unity_XR_Performance_Engineer_Resume) in src/components/Navbar.tsx.
  • Updated public/resume/viewer.html to read an optional title query parameter and set document.title to that value, falling back to the filename-derived title when title is not provided.
  • The viewer still validates file against allowedFiles and defaults to JamesDeRaja_Resume.pdf if an invalid value is passed.

Testing

  • Ran the production build with npm run build and the build completed successfully.

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Ready Ready Preview, Comment Mar 5, 2026 8:38am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant