Make this a proper python module#4
Open
keroe wants to merge 7 commits intoJamesQFreeman:mainfrom
Open
Conversation
add sam later in dep
move the source code to python modules. Move the test code to a proper test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this nice repository! I'm planning to use your code in my upcoming research so I thought it's a good idea to make your code into a proper python package which can be easily imported another python package.
In the same step I removed the offline sam version and added the sam repository as a dependency so it has the most recent version.
Happy to discuss on the changes.