Skip to content

Conversation

@olbris
Copy link
Contributor

@olbris olbris commented May 20, 2025

This fixes JW-52979 in our internal tracker. Error is below for reference. The error is invisible to the user. It happens when clicking on a workspace in the explorer to determine if it is eligible to have the "Delete Workspace" item on its right-click menu.

In the wild, I can't reproduce this bug on command. But it's appeared several times to Mary and Nataliia. Inspection of the code reveals the likely cause: domainObject was sometimes unset before use. I fixed it and verified that the menu item does appear when it should.

@porterbot should definitely review this, as he wrote the original. David should feel free to merge if he approves.

Also @krokicki for general workstation insight, and @stuarteberg because he loves Java.

Error so you don't have to look up the issue:

    java.lang.NullPointerException
    at org.janelia.workstation.controller.action.DeleteHortaWorkspaceAction.processContext(DeleteHortaWorkspaceAction.java:57)
    at org.janelia.workstation.common.actions.BaseContextualNodeAction.enable(BaseContextualNodeAction.java:101)
    at org.janelia.workstation.core.actions.ContextualNodeActionTracker.resultChanged(ContextualNodeActionTracker.java:80)
    at org.openide.util.lookup.SimpleProxyLookup.checkLookup(SimpleProxyLookup.java:114)
    at org.openide.util.lookup.SimpleProxyLookup.lookup(SimpleProxyLookup.java:159)
    at org.netbeans.modules.openide.windows.GlobalActionContextImpl.propertyChange(GlobalActionContextImpl.java:194)
    at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
    at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
    at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
    at org.netbeans.core.windows.RegistryImpl.doFirePropertyChange(RegistryImpl.java:329)
    at org.netbeans.core.windows.RegistryImpl.access$100(RegistryImpl.java:69)
    at org.netbeans.core.windows.RegistryImpl$1.run(RegistryImpl.java:170)
    at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
    at java.awt.EventQueue.access$500(EventQueue.java:97)
    at java.awt.EventQueue$3.run(EventQueue.java:709)
    at java.awt.EventQueue$3.run(EventQueue.java:703)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
    at org.janelia.workstation.common.logging.EDTExceptionInterceptor.dispatchEvent(EDTExceptionInterceptor.java:21)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

@olbris olbris requested a review from porterbot May 20, 2025 15:43
@krokicki
Copy link
Member

LGTM

@porterbot
Copy link
Collaborator

also looks good to me.

@porterbot porterbot merged commit e5fc244 into master May 20, 2025
1 check passed
@porterbot
Copy link
Collaborator

not sure if I was supposed to be the one doing the merge; I apologize if I messed that up.

@olbris olbris deleted the JW-52979 branch May 23, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants