[pull] master from ledgersmb:master by pull[bot] · Pull Request #15 · Jankyboy/LedgerSMB

pull · 2020-09-17T11:14:36Z

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

rtd-helper · 2020-10-12T07:45:42Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-12T07:45:45Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-13T06:18:56Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-16T15:01:46Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-16T16:38:34Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-16T16:58:54Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-18T23:22:41Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-23T20:36:31Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-23T20:36:53Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-23T20:46:40Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-24T13:40:52Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-24T14:53:04Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-25T05:08:11Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-25T17:44:40Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-25T21:55:36Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-25T22:12:46Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-27T18:18:36Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-27T20:29:14Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-27T21:29:03Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-30T09:33:58Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-10-31T08:09:09Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-01T15:38:46Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-02T22:14:43Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-03T06:10:25Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-04T22:45:53Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-08T08:51:12Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-08T21:21:55Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

rtd-helper · 2020-11-10T09:52:42Z

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

Rebuild JS when dependencies change

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…a-docs Add ability to regenerate database documentation to Makefile

…pping Wrap INSERT statements after the table name for easier searching

Remove unused modules affected by schema refactoring

Re #9235

…-ends

…s-not-gl Use 'transactions' table for anything that's not a GL transaction

* Approval is in 'transactions' now, not in 'gl' * Centralize 'transdate' field from AR and AP tables * Centralize 'transdate' field from GL table

Replace the use of 'glnumber' counter with appropriate counters

hound · 2026-02-23T22:18:01Z

UI/jest.config.js

+            displayName: "API",
+            ...common,
+
+            moduleFileExtensions: ["js", "json", "vue"],


Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (96% scanned).

hound · 2026-02-23T22:18:01Z

UI/jest.config.js

+        },
+        {
+            displayName: "API",
+            ...common,


Expected '}' to match '{' from line 295 and instead saw '...'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2026-02-23T22:18:01Z

UI/jest.config.js

+    projects: [
+        {
+            displayName: "browser",
+            ...common,


Expected ']' to match '[' from line 267 and instead saw 'common'.
Expected '}' to match '{' from line 268 and instead saw '...'.

hound · 2026-02-23T22:18:02Z

UI/jest.config.js

+   https://github.com/jestjs/jest/blob/v30.0.0/packages/jest-types/src/Config.ts#L329-L394 was used
+   to manually split the keys between 'common' and the default export below.
+ */
+const common = {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+        expect(buttons).toEqual([
+            ["change-default", "modify", "save", "cancel"],
+            ["change-default", "modify", "save", "cancel"]
+        ]);


Unrecoverable syntax error. (32% scanned).

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+            expect(wrapper.find(".dynatableData").isVisible()).toBe(true)
+        );
+
+        const language_items = wrapper.findAll(".data-row");


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+        expect(wrapper.get(".dynatableLoading").text()).toBe("Loading...");
+
+        // Wait until loading done
+        await retry(() =>


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected an assignment or function call and instead saw an expression.
Missing semicolon.

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+
+    it("should show dialog with editable data", async () => {
+        // Give user edition capability
+        sessionUser.$patch({ roles: ["language_edit"] });


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected ')' and instead saw ';'.
Expected ')' to match '{' from line 48 and instead saw '.'.
Missing semicolon.

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+        // what was returned by the API
+    });
+
+    it("should show dialog with editable data", async () => {


Expected '(' and instead saw '{'.

hound · 2026-02-23T22:18:02Z

UI/tests/specs/views/Languages.spec.js

+
+        // Validate data displayed
+        let data = language_items.map((rows) => {
+            return rows.findAll(".input-box").map((row) => row.element.value);


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

Enhance Makefile

hound · 2026-02-24T21:47:41Z

UI/src/store/countries.js

+
+export const useCountriesStore = defineStore("countries", {
+    ...configStoreTemplate,
+    getters: {


Missing semicolon.
Unrecoverable syntax error. (25% scanned).
const 'getters' is initialized to 'undefined'.

hound · 2026-02-24T21:47:41Z

UI/src/store/countries.js

+let { actions: configActions, getters: configGetters } = configStoreTemplate;
+
+export const useCountriesStore = defineStore("countries", {
+    ...configStoreTemplate,


Expected ')' and instead saw 'configStoreTemplate'.
Expected '}' to match '{' from line 8 and instead saw '...'.

hound · 2026-02-24T21:47:41Z

UI/src/store/countries.js

+
+let { actions: configActions, getters: configGetters } = configStoreTemplate;
+
+export const useCountriesStore = defineStore("countries", {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'export' is only available in ES6 (use 'esversion: 6').

hound · 2026-02-24T21:47:41Z

UI/src/store/countries.js

+import { defineStore } from "pinia";
+import { configStoreTemplate } from "@/store/configTemplate";
+
+let { actions: configActions, getters: configGetters } = configStoreTemplate;


'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:47:41Z

UI/src/store/countries.js

+/** @format */
+
+import { defineStore } from "pinia";
+import { configStoreTemplate } from "@/store/configTemplate";


'import' is only available in ES6 (use 'esversion: 6').

hound · 2026-02-24T21:47:42Z

UI/js-src/lsmb/DateTextBox.js

+                    /* Extract the separator and location into an array and if
+                     * needed add the separator. */
+                    const re = /[^a-z]/gi;
+                    let position;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:47:42Z

UI/js-src/lsmb/DateTextBox.js

+                    }
+                    /* Extract the separator and location into an array and if
+                     * needed add the separator. */
+                    const re = /[^a-z]/gi;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:47:42Z

UI/js-src/lsmb/DateTextBox.js

+                this.domNode,
+                "keyup",
+                lang.hitch(this, function (e) {
+                    let value = domAttr.get(e.target, "value");


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:47:42Z

UI/js-src/lsmb/DateTextBox.js

-            // (unless there's a placeholder already)
+            /* retrieve format to add it as the placeholder
+             * (unless there's a placeholder already) */
+            params.constraints.formatLength ||= "short";


Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw '='.
Missing semicolon.

hound · 2026-02-24T21:47:42Z

UI/js-src/lsmb/Form.js

                        domform.toQuery(this.domNode);
                }
-                registry.byId("maindiv").load_form(url, options);
+                window.__lsmbSubmitForm({ url, options });


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:04Z

UI/js-src/lsmb/Form.js

                c++;
-                var qobj = domform.toQuery(this.domNode);
-                qobj = "action=" + this.clickedAction + "&" + qobj;
+                let qobj = domform.toQuery(this.domNode);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:04Z

UI/js-src/lsmb/Form.js

                typeof this.method === "undefined" ? "GET" : this.method;
-            var url = this.action;
-            var options = { handleAs: "text" };
+            let url =


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/Form.js


-            var method =
+            const options = { handleAs: "text" };
+            const method =


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/Form.js

            }

-            var method =
+            const options = { handleAs: "text" };


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/Form.js

        },
        submit: function () {
-            if (!this.validate()) {
+            const widget = registry.getEnclosingWidget(this.clickedAction);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/parts/PartSelector.js

-                // eslint-disable-next-line no-unused-vars
-                this.on("change", function (newValue) {
-                    topic.publish(self.channel, self.item);
+                this.on("change", () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/parts/PartSelector.js

                this.own(
-                    topic.subscribe(this.channel, function (selected) {
-                        self.set("value", selected[self.searchAttr]);
+                    topic.subscribe(this.channel, (selected) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/payments/PostPrintButton.js

+                let blob = await r.blob();
+                // Create a link pointing to the ObjectURL
+                // containing the blob.
+                const _data = window.URL.createObjectURL(blob);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/payments/PostPrintButton.js

-                }
-            );
+            if (r.ok) {
+                let blob = await r.blob();


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

hound · 2026-02-24T21:56:05Z

UI/js-src/lsmb/payments/PostPrintButton.js

-
-            xhr(domattr.get(f, "action"), {
+            let base = window.location.pathname.replace(/[^/]*$/, "");
+            let r = await fetch(base + domattr.get(f, "action"), {


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

pull bot added the ⤵️ pull label Sep 17, 2020

pr-triage bot added the PR: unreviewed label Oct 12, 2020

ehuelsmann and others added 24 commits February 20, 2026 19:27

Merge pull request #9264 from ehuelsmann/testing/js-rebuild-granularity

b3c85d2

Rebuild JS when dependencies change

fix(deps): update all non-major dependencies (#9271)

0ad078d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add ability to regenerate database documentation to Makefile

73cd2f1

Merge pull request #9274 from ehuelsmann/feature/makefile/regen-schem…

05ad9f4

…a-docs Add ability to regenerate database documentation to Makefile

Wrap INSERT statements after the table name for easier searching

639bf16

Merge pull request #9275 from ehuelsmann/cleanup/insert-statement-wra…

5ee105d

…pping Wrap INSERT statements after the table name for easier searching

Remove unused modules affected by schema refactoring

f2e764e

Merge pull request #9279 from ehuelsmann/cleanup/unused-sql-modules

83c15c6

Remove unused modules affected by schema refactoring

Split GL and non-GL transactions

15aaf32

Move from gl/ar/ap to 'transactions' table

8ec0048

Join with transactions to retrieve fields moved from ar/ap/gl

eb1f636

Adapt old/ to the new paradigm for transactions

8dc53d7

Convert COGS routines from ar/ap+gl to transactions

5d8de3a

Fix invoices API for field moved from ar/ap to transaction

39936b9

Fixes for fields moved from ar/ap/gl to transactions

0653479

Stop creating GL records for overpayments

a9c459b

Re #9235

Deduplicate 'approved' by removing from gl/ar/ap

143bbfb

Re #9235

Don't use GL records for assets, goods, adjustments, payments or year…

55753c2

…-ends

Remove GL records which are in fact something else

7745e2d

Update schema documentation

5048c92

Merge pull request #9235 from ehuelsmann/cleanup/adr/0108-transaction…

09f9f77

…s-not-gl Use 'transactions' table for anything that's not a GL transaction

Centralize transdate field from ar/ap/gl (#9281)

422948c

* Approval is in 'transactions' now, not in 'gl' * Centralize 'transdate' field from AR and AP tables * Centralize 'transdate' field from GL table

Replace the use of 'glnumber' counter with appropriate counters

3ed4971

Merge pull request #9283 from ehuelsmann/cleanup/post-adr-0108

7588bbc

Replace the use of 'glnumber' counter with appropriate counters

hound bot reviewed Feb 23, 2026

View reviewed changes

ehuelsmann added 2 commits February 24, 2026 22:13

Enhance Makefile

f73d0ad

Merge pull request #9284 from ehuelsmann/enhance-makefile

1e4ef0d

Enhance Makefile

hound bot reviewed Feb 24, 2026

View reviewed changes

Move and drop gl.person_id (#9285)

7e3be9f

hound bot reviewed Feb 24, 2026

View reviewed changes


		let { actions: configActions, getters: configGetters } = configStoreTemplate;

		export const useCountriesStore = defineStore("countries", {

Conversation

pull bot commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rtd-helper bot commented Oct 12, 2020

Uh oh!

rtd-helper bot commented Oct 12, 2020

Uh oh!

rtd-helper bot commented Oct 13, 2020

Uh oh!

rtd-helper bot commented Oct 16, 2020

Uh oh!

rtd-helper bot commented Oct 16, 2020

Uh oh!

rtd-helper bot commented Oct 16, 2020

Uh oh!

rtd-helper bot commented Oct 18, 2020

Uh oh!

rtd-helper bot commented Oct 23, 2020

Uh oh!

rtd-helper bot commented Oct 23, 2020

Uh oh!

rtd-helper bot commented Oct 23, 2020

Uh oh!

rtd-helper bot commented Oct 24, 2020

Uh oh!

rtd-helper bot commented Oct 24, 2020

Uh oh!

rtd-helper bot commented Oct 25, 2020

Uh oh!

rtd-helper bot commented Oct 25, 2020

Uh oh!

rtd-helper bot commented Oct 25, 2020

Uh oh!

rtd-helper bot commented Oct 25, 2020

Uh oh!

rtd-helper bot commented Oct 27, 2020

Uh oh!

rtd-helper bot commented Oct 27, 2020

Uh oh!

rtd-helper bot commented Oct 27, 2020

Uh oh!

rtd-helper bot commented Oct 30, 2020

Uh oh!

rtd-helper bot commented Oct 31, 2020

Uh oh!

rtd-helper bot commented Nov 1, 2020

Uh oh!

rtd-helper bot commented Nov 2, 2020

Uh oh!

rtd-helper bot commented Nov 3, 2020

Uh oh!

rtd-helper bot commented Nov 4, 2020

Uh oh!

rtd-helper bot commented Nov 8, 2020

Uh oh!

rtd-helper bot commented Nov 8, 2020

Uh oh!

rtd-helper bot commented Nov 10, 2020

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

hound bot Feb 23, 2026

Choose a reason for hiding this comment

pull bot commented Sep 17, 2020 •

edited

Loading