[pull] master from krakenjs:master#3
Conversation
|
Hey there! 👋 This repository uses the Prettier code style. You forgot to format these files in your pull request:
The Prettier installation guide ❤️ Your friendly Prettifier bot |
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of cf323be. Here's the output:
|
|
The rtd-bot is activated, but no .github/config.yml found in this repository. |
|
The rtd-bot is activated, but no .github/config.yml found in this repository. |
|
The rtd-bot is activated, but no .github/config.yml found in this repository. |
|
The rtd-bot is activated, but no .github/config.yml found in this repository. |
|
The rtd-bot is activated, but no .github/config.yml found in this repository. |
* chore: add tests related to zoid prop usage in the wild
* Pass container to prop definitions when available (#376) * Avoid re-decorating the same prop multiple times * Only use node 14 for github ci
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| export function getGlobal<T>(win : CrossDomainWindowType) : T { |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).
Expected '(' and instead saw '<'.
Expected ')' to match '(' from line 14 and instead saw ':'.
Expected ')' to match '<' from line 14 and instead saw '>'.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ')'.
Missing semicolon.
Unrecoverable syntax error. (35% scanned).
| export function getGlobal(win? : CrossDomainWindowType = window) : Object { | ||
| export function getGlobalKey() : string { | ||
| if (__ZOID__.__SCRIPT_NAMESPACE__) { | ||
| return `${ __ZOID__.__GLOBAL_KEY__ }_${ getCurrentScriptUID() }`; |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
| import { getCurrentScriptUID } from 'belter/src'; | ||
|
|
||
| export function getGlobal(win? : CrossDomainWindowType = window) : Object { | ||
| export function getGlobalKey() : string { |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw ':'.
Missing semicolon.
| /* @flow */ | ||
|
|
||
| import { isSameDomain, type CrossDomainWindowType } from 'cross-domain-utils/src'; | ||
| import { getCurrentScriptUID } from 'belter/src'; |
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
|
|
||
| import { runOnClick } from '../common'; | ||
| import { zoid } from '../zoid'; | ||
| import { runOnClick, getBody } from '../common'; |
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
| var req = new XMLHttpRequest(); | ||
| var detectFunc = function () { }; | ||
| req.onreadystatechange = detectFunc; | ||
| var result = req[zoneSymbol('fakeonreadystatechange')] === detectFunc; |
There was a problem hiding this comment.
'result' is already defined.
Too many errors. (89% scanned).
| this[zoneSymbol('fakeonreadystatechange')] = value; | ||
| } | ||
| }); | ||
| var req = new XMLHttpRequest(); |
| } | ||
| } | ||
| patchOnProperties(XMLHttpRequest.prototype, XMLHttpRequestEventNames); | ||
| var XMLHttpRequestEventTarget = _global['XMLHttpRequestEventTarget']; |
There was a problem hiding this comment.
['XMLHttpRequestEventTarget'] is better written in dot notation.
| patchOnProperties(HTMLBodyElement.prototype, windowEventNames.concat(frameSetEventNames)); | ||
| patchOnProperties(HTMLFrameElement.prototype, frameEventNames); | ||
| patchOnProperties(HTMLIFrameElement.prototype, frameEventNames); | ||
| var HTMLMarqueeElement_1 = window['HTMLMarqueeElement']; |
There was a problem hiding this comment.
['HTMLMarqueeElement'] is better written in dot notation.
| patchOnProperties(window, eventNames, Object.getPrototypeOf(window)); | ||
| patchOnProperties(Document.prototype, eventNames); | ||
| if (typeof window['SVGElement'] !== 'undefined') { | ||
| patchOnProperties(window['SVGElement'].prototype, eventNames); |
There was a problem hiding this comment.
['SVGElement'] is better written in dot notation.
13 participants
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )