-
Notifications
You must be signed in to change notification settings - Fork 193
Added Mr Salmon's Baked Ambient Occlusion #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| ### Colors and Opacity | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JannisX11 Do you know if this image link is correctly configured to work within Blockbench?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Blockbench doesn't handle images that are part of plugins. You will need to link to a full web address where the image is hosted, you can look at the mesh_tools plugin for example as a reference.
|
Hey, I took a look today, here are some notes:
No major notes on the functionality of the plugin itself. It's integrated pretty nicely and works well. |
|
Thanks @JannisX11. |
This PR adds a plugin which allows baked world-space ambient occlusion, to create an instant first-pass at shading.
If there are any changes needed to have this merged, please let me know!