Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ env:
- MODULE='hbase-parent/janusgraph-hbase-10' ARGS='-Dtest=**/graphdb/hbase/*'
- MODULE='hbase-parent/janusgraph-hbase-098' ARGS='-Dtest=**/diskstorage/hbase/*'
- MODULE='hbase-parent/janusgraph-hbase-098' ARGS='-Dtest=**/graphdb/hbase/*'
- MODULE='cql'

matrix:
fast_finish: true
Expand All @@ -47,6 +48,7 @@ matrix:
# Can fail due to timeout (runs longer than 50min)
- env: MODULE='hbase-parent/janusgraph-hbase-098' ARGS='-Dtest=**/diskstorage/hbase/*'
- env: MODULE='hbase-parent/janusgraph-hbase-098' ARGS='-Dtest=**/graphdb/hbase/*'
- env: MODULE='cql'

addons:
coverity_scan:
Expand Down
1 change: 1 addition & 0 deletions AUTHORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ DataStax
Dylan Bethune-Waddell <dylan.bethune.waddell@mail.utoronto.ca>
Expero
Google
Orion Health
IBM
Rafael Fernandes <luizrafael@gmail.com>
2 changes: 2 additions & 0 deletions CONTRIBUTORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ Mike McMahon <mmcm@comcast.net>
Misha Brukman <mbrukman@google.com>
MrKeyholder <fractalf@gmail.com>
Nik Everett <neverett@wikimedia.org>
Paul Kendall <paul.kendall@orionhealth.com> <pkendall64@gmail.com>
Pavel Yaskevich <pyaskevich@twitter.com> <xedin@apache.org>
Peter Beaman <pbeaman@akiban.com>
Petter Aas <aaspet@gmail.com> <petter.aas@fronter.com>
Expand All @@ -82,6 +83,7 @@ PommeVerte <dylan.millikin@gmail.com>
Rafael Fernandes <luizrafael@gmail.com>
Ranger Tsao <cao.zhifu@gmail.com>
Richard Doll <rdoll@care-view.com>
Samant Maharaj <samant.maharaj@orionhealth.com>
Sebastian Good <sebastian@experoinc.com>
Solon Gordon <solon@knewton.com>
Stephen Mallette <spmallette@gmail.com> <spmva@genoprime.com>
Expand Down
5 changes: 5 additions & 0 deletions janusgraph-all/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
<artifactId>janusgraph-cassandra</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-cql</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-berkeleyje</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public void loadStandard(Class<?> caller) {
"org.janusgraph.diskstorage.cassandra.astyanax.AstyanaxStoreManager",
"org.janusgraph.diskstorage.cassandra.AbstractCassandraStoreManager",
"org.janusgraph.diskstorage.cassandra.thrift.CassandraThriftStoreManager",
"org.janusgraph.diskstorage.cql.CQLConfigOptions",
"org.janusgraph.diskstorage.es.ElasticSearchIndex",
"org.janusgraph.diskstorage.solr.SolrIndex",
"org.janusgraph.diskstorage.log.kcvs.KCVSLog",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public enum StandardStoreManager {
CASSANDRA_THRIFT("org.janusgraph.diskstorage.cassandra.thrift.CassandraThriftStoreManager", "cassandrathrift"),
CASSANDRA_ASTYANAX("org.janusgraph.diskstorage.cassandra.astyanax.AstyanaxStoreManager", ImmutableList.of("cassandra", "astyanax")),
CASSANDRA_EMBEDDED("org.janusgraph.diskstorage.cassandra.embedded.CassandraEmbeddedStoreManager", "embeddedcassandra"),
CQL("org.janusgraph.diskstorage.cql.CQLStoreManager", "cql"),
HBASE("org.janusgraph.diskstorage.hbase.HBaseStoreManager", "hbase"),
IN_MEMORY("org.janusgraph.diskstorage.keycolumnvalue.inmemory.InMemoryStoreManager", "inmemory");

Expand Down
314 changes: 314 additions & 0 deletions janusgraph-cql/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,314 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph</artifactId>
<version>0.2.0-SNAPSHOT</version>
</parent>

<artifactId>janusgraph-cql</artifactId>
<name>JanusGraph-CQL: Distributed Graph Database</name>
<url>http://janusgraph.org</url>

<properties>
<cassandra-driver.version>3.1.4</cassandra-driver.version>
<javaslang.version>2.0.5</javaslang.version>

<test.byteorderedpartitioner>byteorderedpartitioner</test.byteorderedpartitioner>
<test.murmur>murmur</test.murmur>
<test.murmur-ssl>murmur-ssl</test.murmur-ssl>
<test.jvm.opts>-Xms256m -Xmx1280m -ea -XX:+HeapDumpOnOutOfMemoryError -javaagent:${com.github.jbellis:jamm:jar}</test.jvm.opts>
<test.excluded.groups>org.janusgraph.testcategory.MemoryTests,org.janusgraph.testcategory.PerformanceTests,org.janusgraph.testcategory.BrittleTests</test.excluded.groups>
</properties>

<dependencies>
<!-- Compile Dependencies -->
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-core</artifactId>
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>com.datastax.cassandra</groupId>
<artifactId>cassandra-driver-core</artifactId>
<version>${cassandra-driver.version}</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>io.javaslang</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one has been changed to vavr.io so not sure if you want to change it now given potential naming conflict from Oracle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated ticked #271 with a link to a branch in our repo with this migration. I'll create a PR once this is merged.

<artifactId>javaslang</artifactId>
<version>${javaslang.version}</version>
</dependency>

<!-- Test Dependencies -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-cassandra</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-cassandra</artifactId>
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.janusgraph</groupId>
<artifactId>janusgraph-test</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<build>
<testResources>
<testResource>
<directory>src/test/resources</directory>
<excludes>
<exclude>cassandra/</exclude>
<exclude>keystores/</exclude>
<exclude>properties/</exclude>
</excludes>
<filtering>true</filtering>
</testResource>
</testResources>
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>set-dependency-properties</id>
<phase>process-test-classes</phase>
<goals>
<goal>properties</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<executions>
<execution>
<id>filter-${test.byteorderedpartitioner}</id>
<phase>process-test-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/cassandra/${test.byteorderedpartitioner}/conf</outputDirectory>
<filters>
<filter>${project.build.testResources[0].directory}/properties/${test.byteorderedpartitioner}.properties</filter>
</filters>
<resources>
<resource>
<directory>${project.build.testResources[0].directory}/cassandra</directory>
<filtering>true</filtering>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>filter-${test.murmur}</id>
<phase>process-test-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/cassandra/${test.murmur}/conf</outputDirectory>
<filters>
<filter>${project.build.testResources[0].directory}/properties/${test.murmur}.properties</filter>
</filters>
<resources>
<resource>
<directory>${project.build.testResources[0].directory}/cassandra</directory>
<filtering>true</filtering>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>filter-${test.murmur-ssl}</id>
<phase>process-test-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/cassandra/${test.murmur-ssl}/conf</outputDirectory>
<filters>
<filter>${project.build.testResources[0].directory}/properties/${test.murmur-ssl}.properties</filter>
</filters>
<resources>
<resource>
<directory>${project.build.testResources[0].directory}/cassandra</directory>
<filtering>true</filtering>
</resource>
</resources>
</configuration>
</execution>
<execution>
<id>filter-${test.murmur-ssl}-static</id>
<phase>process-test-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/cassandra/${test.murmur-ssl}/conf</outputDirectory>
<resources>
<resource>
<directory>${project.build.testResources[0].directory}/keystores</directory>
<filtering>false</filtering>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>${test.jvm.opts}</argLine>
<forkCount>1</forkCount>
<reuseForks>false</reuseForks>
<parallel>classes</parallel>
<perCoreThreadCount>true</perCoreThreadCount>
<threadCount>2</threadCount>
<runOrder>random</runOrder>
<systemPropertyVariables>
<log4j.configuration>file:${project.build.testOutputDirectory}/log4j.properties</log4j.configuration>
</systemPropertyVariables>
</configuration>
<executions>
<execution>
<id>default-test</id>
<phase>none</phase>
</execution>
<execution>
<id>${test.byteorderedpartitioner}-test</id>
<goals>
<goal>test</goal>
</goals>
<phase>test</phase>
<configuration>
<excludedGroups>${test.excluded.groups},org.janusgraph.testcategory.UnorderedKeyStoreTests,org.janusgraph.testcategory.SerialTests,org.janusgraph.testcategory.CassandraSSLTests</excludedGroups>
<groups />
<reportNameSuffix>${test.byteorderedpartitioner}</reportNameSuffix>
<systemProperties>
<property>
<name>test.cassandra.confdir</name>
<value>${project.build.directory}/cassandra/${test.byteorderedpartitioner}/conf</value>
</property>
<property>
<name>test.cassandra.datadir</name>
<value>${project.build.directory}/cassandra/${test.byteorderedpartitioner}/data</value>
</property>
</systemProperties>
<skip>${test.skip.byteorderedpartitioner}</skip>
</configuration>
</execution>
<execution>
<id>${test.murmur}-test</id>
<goals>
<goal>test</goal>
</goals>
<phase>test</phase>
<configuration>
<excludedGroups>${test.excluded.groups},org.janusgraph.testcategory.OrderedKeyStoreTests,org.janusgraph.testcategory.SerialTests,org.janusgraph.testcategory.CassandraSSLTests</excludedGroups>
<groups />
<reportNameSuffix>${test.murmur}</reportNameSuffix>
<systemProperties>
<property>
<name>test.cassandra.confdir</name>
<value>${project.build.directory}/cassandra/${test.murmur}/conf</value>
</property>
<property>
<name>test.cassandra.datadir</name>
<value>${project.build.directory}/cassandra/${test.murmur}/data</value>
</property>
</systemProperties>
<skip>${test.skip.murmur}</skip>
</configuration>
</execution>
<execution>
<id>${test.murmur}-serial-test</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is run by default in janusgraph-cql but not under janusgraph-cassandra. Expect default test executions to be consistent (though maybe it should be enabled by default in janusgraph-cassandra?)

<goals>
<goal>test</goal>
</goals>
<phase>test</phase>
<configuration>
<excludedGroups />
<groups>org.janusgraph.testcategory.SerialTests</groups>
<parallel>none</parallel>
<perCoreThreadCount>false</perCoreThreadCount>
<threadCount>1</threadCount>
<runOrder>alphabetical</runOrder>
<reportNameSuffix>${test.murmur}-serial</reportNameSuffix>
<systemProperties>
<property>
<name>test.cassandra.confdir</name>
<value>${project.build.directory}/cassandra/${test.murmur}/conf</value>
</property>
<property>
<name>test.cassandra.datadir</name>
<value>${project.build.directory}/cassandra/${test.murmur}/data</value>
</property>
</systemProperties>
<skip>${test.skip.murmur-serial}</skip>
</configuration>
</execution>
<execution>
<id>${test.murmur-ssl}-test</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above ... this test execution is run by default in janusgraph-cql but not under janusgraph-cassandra

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the serial and SSL tests, it appears to me that they both run by default in janusgraph-cassandra unless the appropriate skip property is defined.

I believe the janusgraph-cql module has the same behaviour but happy to change if this isn't correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry about that. I was comparing to a cassandra log I had on hand but now I see in that case there was a failure in the bop-test execution so the others didn't run.

<goals>
<goal>test</goal>
</goals>
<phase>test</phase>
<configuration>
<excludedGroups />
<groups>org.janusgraph.testcategory.CassandraSSLTests</groups>
<!-- The TP3 JUnit Suite/Runner ignores groups/@Category and I'm not sure why. Redundant excludes to keep TP3 tests from using non-SSL configs on SSL -->
<excludes>
<exclude>**/*ComputerTest.java</exclude>
<exclude>**/*StructureTest.java</exclude>
<exclude>**/*ProcessTest.java</exclude>
</excludes>
<threadCount>1</threadCount>
<reportNameSuffix>${test.murmur-ssl}</reportNameSuffix>
<systemProperties>
<property>
<name>test.cassandra.confdir</name>
<value>${project.build.directory}/cassandra/${test.murmur-ssl}/conf</value>
</property>
<property>
<name>test.cassandra.datadir</name>
<value>${project.build.directory}/cassandra/${test.murmur-ssl}/data</value>
</property>
</systemProperties>
<skip>${test.skip.murmur-ssl}</skip>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Loading