Skip to content

Conversation

@msung99
Copy link

@msung99 msung99 commented Sep 2, 2024

No description provided.

@msung99 msung99 self-assigned this Sep 2, 2024
@msung99 msung99 requested review from alreadysons and lxeso September 2, 2024 12:03
@msung99 msung99 removed their assignment Sep 3, 2024

// 포비의 결과 리스트를 구한다.
List<Integer> pobiResultList = List.of(getSumValue(pobiLeftPage), getSumValue(pobiRightPage),
getMultiplyValue(pobiLeftPage), getMultiplyValue(pobiRightPage));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left,right 페이지의 sum,multiply값을 합쳐서 리스트를 통해 MAX값을 구하는 점이 인상깊었습니다!

Copy link
Member

@dayaelee dayaelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고려해야할 예외 케이스를 세세하게 고려하여 코드를 잘 작성하신 것 같습니다 !

Stack<Character> stack = new Stack<>();

for (char c : cryptogram.toCharArray()) {
if (!stack.isEmpty() && stack.peek() == c) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack을 이용한 점 인상깊었습니다

Copy link

@alreadysons alreadysons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

Set<String> userFriends = new HashSet<>();

// 사용자와 친구인 사람들 기록
for (List<String> pair : friends) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 함수로 따로 빼서 안하신 이유가 있을까용??

return answer;
StringBuilder result = new StringBuilder();

for (char c : word.toCharArray()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 간결하고 좋습니다 해당 방법 저도 습득해야겠습니다

List<Integer> result = new ArrayList<>();

// 각 화폐 단위에 대해 몫을 구하고 나머지를 계산
for (int unit : units) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저랑 비슷하게 문제 해결하신 것 같습니다!

String nickname2 = forms.get(j).get(1);

if (hasCommonSubstring(nickname1, nickname2)) {
duplicateEmails.add(email1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굉장히 간결하네요 get을 이렇게도 사용할 수 있군요

return a.compareTo(b);
});

// 최대 5명까지만 추천
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세세하게 주석 작성하여 코드작성 잘 하신것 같습니다 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants