-
Notifications
You must be signed in to change notification settings - Fork 5
[java-onboarding-week-1] haon.lee(이민성) 과제 제출합니다. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: haon/java-onboarding-week-1
Are you sure you want to change the base?
[java-onboarding-week-1] haon.lee(이민성) 과제 제출합니다. #2
Conversation
|
|
||
| // 포비의 결과 리스트를 구한다. | ||
| List<Integer> pobiResultList = List.of(getSumValue(pobiLeftPage), getSumValue(pobiRightPage), | ||
| getMultiplyValue(pobiLeftPage), getMultiplyValue(pobiRightPage)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left,right 페이지의 sum,multiply값을 합쳐서 리스트를 통해 MAX값을 구하는 점이 인상깊었습니다!
dayaelee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고려해야할 예외 케이스를 세세하게 고려하여 코드를 잘 작성하신 것 같습니다 !
| Stack<Character> stack = new Stack<>(); | ||
|
|
||
| for (char c : cryptogram.toCharArray()) { | ||
| if (!stack.isEmpty() && stack.peek() == c) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stack을 이용한 점 인상깊었습니다
alreadysons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!!
| Set<String> userFriends = new HashSet<>(); | ||
|
|
||
| // 사용자와 친구인 사람들 기록 | ||
| for (List<String> pair : friends) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 함수로 따로 빼서 안하신 이유가 있을까용??
| return answer; | ||
| StringBuilder result = new StringBuilder(); | ||
|
|
||
| for (char c : word.toCharArray()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 간결하고 좋습니다 해당 방법 저도 습득해야겠습니다
| List<Integer> result = new ArrayList<>(); | ||
|
|
||
| // 각 화폐 단위에 대해 몫을 구하고 나머지를 계산 | ||
| for (int unit : units) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저랑 비슷하게 문제 해결하신 것 같습니다!
| String nickname2 = forms.get(j).get(1); | ||
|
|
||
| if (hasCommonSubstring(nickname1, nickname2)) { | ||
| duplicateEmails.add(email1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굉장히 간결하네요 get을 이렇게도 사용할 수 있군요
| return a.compareTo(b); | ||
| }); | ||
|
|
||
| // 최대 5명까지만 추천 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세세하게 주석 작성하여 코드작성 잘 하신것 같습니다 !
No description provided.