forked from cho-log/spring-learning-test
-
Notifications
You must be signed in to change notification settings - Fork 5
[spring-core-1] haon.lee(이민성) 과제 제출합니다. #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msung99
wants to merge
14
commits into
Japring-Study:haon/spring-core-1
Choose a base branch
from
msung99:haon/spring-core-1
base: haon/spring-core-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[spring-core-1] haon.lee(이민성) 과제 제출합니다. #38
msung99
wants to merge
14
commits into
Japring-Study:haon/spring-core-1
from
msung99:haon/spring-core-1
+61
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swandevson
reviewed
Aug 15, 2024
swandevson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdbc-1이랑 커밋이 같이 꼬여있네요
이 부분 다음에 주의하셔서 브랜치 관리해주시면 좋을 것 같습니다!
|
잘 하신것 같습니다 고생하셨습니다!! |
dayaelee
reviewed
Aug 19, 2024
Member
dayaelee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
목적에 맞게 코드를 잘 작성하신 것 같습니다. 고생하셨습니다 하온!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
하온 미션 제출합니다. 이번 커밋 내역에 JDBC 내용도 함께 올라갔는데, 양해 부탁드려요 🥹