Harden publish workflow logs against command injection#1
Open
JaredStowell wants to merge 1 commit intomainfrom
Open
Harden publish workflow logs against command injection#1JaredStowell wants to merge 1 commit intomainfrom
JaredStowell wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
::command::sequences and tamper with CI logs.Description
log_literal()helper in theGenerate release summaryandNotify Google Chatsteps that wraps untrusted output with a::stop-commands::{token}marker and the matching closing token so runners treat the block as literal text.echocalls withlog_literalfor the commit list, AI-generated summary, webhook payload, and webhook response to ensure any::command::sequences in that content are not interpreted by the runner.GITHUB_OUTPUTand sending the Google Chat webhook.Testing
sed -n '1,240p' .github/workflows/publish.ymlto confirm thelog_literal()helper and replacements were added, and checked the updated region withnl -ba .github/workflows/publish.yml | sed -n '90,230p', which succeeded.rg --files -g 'AGENTS.md'and confirmed the modified workflow shows the new safe logging calls; these checks succeeded.Codex Task