fix: strip export-from server data exports in client transform#7
Open
JaredStowell wants to merge 1 commit intomainfrom
Open
fix: strip export-from server data exports in client transform#7JaredStowell wants to merge 1 commit intomainfrom
JaredStowell wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
stripServerExportsskippedExportNamedDeclarationnodes that have asource(patterns likeexport { getServerSideProps } from './server'), leaving server-only data-fetching exports in client bundles and potentially exposing server-only code.Description
stripServerExportsinpackages/vinext/src/index.tsto processExportNamedDeclarationspecifiers regardless ofnode.sourcesoexport ... from '...'patterns are handled.from '...'source) while replacing server-only specifiers with stubbedexport const <name> = undefined;lines for mixed re-exports.tests/build-optimization.test.tscovering pureexport-fromserver exports and mixed specifier cases to prevent regressions.Testing
pnpm vitest run tests/build-optimization.test.ts -t "handles export-from", and the targeted tests passed.tests/build-optimization.test.tsand the new cases pass under the targeted Vitest run.Codex Task