-
Notifications
You must be signed in to change notification settings - Fork 3
kmj - 사다리 게임 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jyami-kim
wants to merge
19
commits into
Java-Bom:kmj
Choose a base branch
from
jyami-kim:kmj
base: kmj
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
kmj - 사다리 게임 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pci2676
reviewed
May 3, 2019
chldbtjd2272
reviewed
May 5, 2019
kmj - 사다리게임
1. package 설계 다시하기 각 List, List 생성부분 maker라는 class로 분리하기 throw error 처리 factory method 패턴 : PillarFactory test code 수정 2. output view 수정 bridge와 높이 들고있는 dto로 만들기 (가로로 출력할 수 있는 dto로 만들기) converter class로 분리 : bridge 1개와 level 들고있는 찍기 편한 형태로 변환 (flatMap) 3. 마지막 요구사항 추가하기 실행결과 유저와 실행 결과 매칭해서 output 보여주기 - user class에서 calc 메소드 만들어서 구현 사다리 input output 결과 매칭하기
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.