Skip to content

add multi_client example, partial support for config rest endpoints, minor bug fixes#2

Merged
JayceFayne merged 1 commit intoJayceFayne:masterfrom
dsandall:master
Jan 29, 2026
Merged

add multi_client example, partial support for config rest endpoints, minor bug fixes#2
JayceFayne merged 1 commit intoJayceFayne:masterfrom
dsandall:master

Conversation

@dsandall
Copy link
Copy Markdown
Contributor

@dsandall dsandall commented Jan 9, 2026

Everything should be pretty clear from the commit messages. Let me know if I can improve anything, or if I missed anything simple. I am hoping to add the config endpoints for a downstream tool I am building.

Copy link
Copy Markdown
Owner

@JayceFayne JayceFayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added some comments.

Also, in general, changes to the async public API need to be reflected in the blocking API as well.

Comment thread Cargo.toml
Comment thread async/src/client.rs Outdated
Comment thread async/src/client.rs Outdated
Comment thread async/src/client.rs Outdated
Comment thread async/src/client.rs Outdated
Comment thread examples/multi_client/src/main.rs Outdated
Comment thread types/src/config/folders.rs Outdated
Comment thread types/src/events.rs Outdated
Comment thread blocking/src/client.rs Outdated
Comment thread blocking/src/client.rs Outdated
Comment thread blocking/src/client.rs Outdated
Comment thread types/src/config/folders.rs Outdated
Comment thread types/src/config/folders.rs Outdated
Comment thread examples/multi_client_async/Cargo.toml Outdated
Comment thread examples/multi_client/Cargo.toml Outdated
@JayceFayne
Copy link
Copy Markdown
Owner

LGTM! Could you squash the commits a bit so we end up with a few clean, logical commits? Thanks!

 - added support for rest/config/folders, rest/config/devices, and rest/db/status endpoints
 - implement authority accessor
@dsandall
Copy link
Copy Markdown
Contributor Author

squashed into one big commit, hope that's cool - thanks for the pointers, and the project!

@JayceFayne
Copy link
Copy Markdown
Owner

All good, thanks for squashing. Really appreciate the contribution and the care you put into it!

@JayceFayne JayceFayne merged commit 452da54 into JayceFayne:master Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants