Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-select/src/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ export interface Props<
/** Handle the menu closing */
onMenuClose: () => void;
/** Fired when the user scrolls to the top of the menu */
onMenuScrollToTop?: (event: WheelEvent | TouchEvent) => void;
onMenuScrollToTop?: (event: Event) => void;
/** Fired when the user scrolls to the bottom of the menu */
onMenuScrollToBottom?: (event: WheelEvent | TouchEvent) => void;
onMenuScrollToBottom?: (event: Event) => void;
/** Allows control of whether the menu is opened when the Select is focused */
openMenuOnFocus: boolean;
/** Allows control of whether the menu is opened when the Select is clicked */
Expand Down
8 changes: 4 additions & 4 deletions packages/react-select/src/internal/ScrollManager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ interface Props {
readonly children: (ref: RefCallback<HTMLElement>) => ReactElement;
readonly lockEnabled: boolean;
readonly captureEnabled: boolean;
readonly onBottomArrive?: (event: WheelEvent | TouchEvent) => void;
readonly onBottomLeave?: (event: WheelEvent | TouchEvent) => void;
readonly onTopArrive?: (event: WheelEvent | TouchEvent) => void;
readonly onTopLeave?: (event: WheelEvent | TouchEvent) => void;
readonly onBottomArrive?: (event: Event) => void;
readonly onBottomLeave?: (event: Event) => void;
readonly onTopArrive?: (event: Event) => void;
readonly onTopLeave?: (event: Event) => void;
}

const blurSelectInput = (event: MouseEvent<HTMLDivElement>) => {
Expand Down
39 changes: 24 additions & 15 deletions packages/react-select/src/internal/useScrollCapture.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import { useCallback, useEffect, useRef } from 'react';
import { supportsPassiveEvents } from '../utils';

const cancelScroll = (event: WheelEvent | TouchEvent) => {
const cancelScroll = (event: Event) => {
if (event.cancelable) event.preventDefault();
event.stopPropagation();
};

interface Options {
readonly isEnabled: boolean;
readonly onBottomArrive?: (event: WheelEvent | TouchEvent) => void;
readonly onBottomLeave?: (event: WheelEvent | TouchEvent) => void;
readonly onTopArrive?: (event: WheelEvent | TouchEvent) => void;
readonly onTopLeave?: (event: WheelEvent | TouchEvent) => void;
readonly onBottomArrive?: (event: Event) => void;
readonly onBottomLeave?: (event: Event) => void;
readonly onTopArrive?: (event: Event) => void;
readonly onTopLeave?: (event: Event) => void;
}

export default function useScrollCapture({
Expand All @@ -25,9 +25,10 @@ export default function useScrollCapture({
const isTop = useRef(false);
const touchStart = useRef(0);
const scrollTarget = useRef<HTMLElement | null>(null);
const previousScrollTop = useRef(0);

const handleEventDelta = useCallback(
(event: WheelEvent | TouchEvent, delta: number) => {
(event: Event, delta: number) => {
if (scrollTarget.current === null) return;

const { scrollTop, scrollHeight, clientHeight } = scrollTarget.current;
Expand Down Expand Up @@ -73,16 +74,24 @@ export default function useScrollCapture({
[onBottomArrive, onBottomLeave, onTopArrive, onTopLeave]
);

const onWheel = useCallback(
(event: WheelEvent) => {
handleEventDelta(event, event.deltaY);
const onScroll = useCallback(
(event: Event) => {
const target = event.currentTarget;

if (target instanceof HTMLElement) {
const deltaY = target.scrollTop - previousScrollTop.current;
previousScrollTop.current = target.scrollTop;
handleEventDelta(event, deltaY);
}
},
[handleEventDelta]
);

const onTouchStart = useCallback((event: TouchEvent) => {
// set touch start so we can calculate touchmove delta
touchStart.current = event.changedTouches[0].clientY;
}, []);

const onTouchMove = useCallback(
(event: TouchEvent) => {
const deltaY = touchStart.current - event.changedTouches[0].clientY;
Expand All @@ -92,28 +101,28 @@ export default function useScrollCapture({
);

const startListening = useCallback(
(el) => {
(el: HTMLElement | null) => {
// bail early if no element is available to attach to
if (!el) return;

const notPassive = supportsPassiveEvents ? { passive: false } : false;
el.addEventListener('wheel', onWheel, notPassive);
el.addEventListener('scroll', onScroll, notPassive);
el.addEventListener('touchstart', onTouchStart, notPassive);
el.addEventListener('touchmove', onTouchMove, notPassive);
},
[onTouchMove, onTouchStart, onWheel]
[onTouchMove, onTouchStart, onScroll]
);

const stopListening = useCallback(
(el) => {
(el: HTMLElement | null) => {
// bail early if no element is available to detach from
if (!el) return;

el.removeEventListener('wheel', onWheel, false);
el.removeEventListener('scroll', onScroll, false);
el.removeEventListener('touchstart', onTouchStart, false);
el.removeEventListener('touchmove', onTouchMove, false);
},
[onTouchMove, onTouchStart, onWheel]
[onTouchMove, onTouchStart, onScroll]
);

useEffect(() => {
Expand Down