Open
Conversation
Owner
|
This looks like a nice improvement. Bummer this PR breaks all the tests, but that's probably OK since I've been meaning to refactor to phpunit anyhow. This should give me the motivation to do it! |
Author
|
I probably broke the dependency loading in the tests. I'd recommend moving those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started a quick sketch to implement composer for this package.
I'm not familiar with the simpletest framework, so I just included the dev-dependency, but didn't refactor out the require calls.
Please review and lmk!