Conversation
There was a problem hiding this comment.
please put the changes you want in qtl-analysis, not a new script
There was a problem hiding this comment.
We are not using any of .hipo output, produced by qtl-histogram. Should we still need qtl-analysis?
There was a problem hiding this comment.
please put the changes you want in run_analysis.groovy, not a new script
There was a problem hiding this comment.
Again, it's not analysis of histogram from qtl-histogram. Does it have to be in run_analysis.groovy?
| println([name,timelineArg,engine.getClass().getSimpleName(),inputDir]) | ||
| def fnames = [] | ||
| inputDir.traverse { | ||
| if(it.name.endsWith('.daq.config') && it.name.contains(name)) |
There was a problem hiding this comment.
what produces these *.daq.config files?
There was a problem hiding this comment.
Probably evio2xml -maxevents 0 /cache/clas12/rg-l/data/clas_0[run]/clas_0[run].evio.00000 | grep PETIROC_REG_VTH_TIME >> [run]/out_ALERT_[run].daq.config
There was a problem hiding this comment.
It's not even in a hipo format. It's just txt file like,
PETIROC_REG_VTH_TIME 200 # Use value below ~400 for ALERT ATOF signals
#PETIROC_REG_VTH_TIME 500 # Use value above ~400 for Pulser Injector signals
PETIROC_REG_VTH_TIME 200 # Use value below ~400 for ALERT ATOF signals
#PETIROC_REG_VTH_TIME 500 # Use value above ~400 for Pulser Injector signals
PETIROC_REG_VTH_TIME 312
PETIROC_REG_VTH_TIME 312
PETIROC_REG_VTH_TIME 304
PETIROC_REG_VTH_TIME 304
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 310
PETIROC_REG_VTH_TIME 310
PETIROC_REG_VTH_TIME 296
PETIROC_REG_VTH_TIME 296
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 300
PETIROC_REG_VTH_TIME 300
PETIROC_REG_VTH_TIME 316
PETIROC_REG_VTH_TIME 316
PETIROC_REG_VTH_TIME 286
PETIROC_REG_VTH_TIME 286
PETIROC_REG_VTH_TIME 294
PETIROC_REG_VTH_TIME 294
PETIROC_REG_VTH_TIME 298
PETIROC_REG_VTH_TIME 298
PETIROC_REG_VTH_TIME 324
PETIROC_REG_VTH_TIME 324
PETIROC_REG_VTH_TIME 302
PETIROC_REG_VTH_TIME 302
PETIROC_REG_VTH_TIME 344
PETIROC_REG_VTH_TIME 344
PETIROC_REG_VTH_TIME 304
PETIROC_REG_VTH_TIME 304
PETIROC_REG_VTH_TIME 114
PETIROC_REG_VTH_TIME 114
PETIROC_REG_VTH_TIME 50
PETIROC_REG_VTH_TIME 50
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 434
PETIROC_REG_VTH_TIME 434
PETIROC_REG_VTH_TIME 82
PETIROC_REG_VTH_TIME 82
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 306
PETIROC_REG_VTH_TIME 210
PETIROC_REG_VTH_TIME 210
PETIROC_REG_VTH_TIME 242
PETIROC_REG_VTH_TIME 242
PETIROC_REG_VTH_TIME 482
PETIROC_REG_VTH_TIME 482
PETIROC_REG_VTH_TIME 402
PETIROC_REG_VTH_TIME 402
PETIROC_REG_VTH_TIME 338
PETIROC_REG_VTH_TIME 338
PETIROC_REG_VTH_TIME 138
PETIROC_REG_VTH_TIME 138
PETIROC_REG_VTH_TIME 466
PETIROC_REG_VTH_TIME 466
PETIROC_REG_VTH_TIME 106
PETIROC_REG_VTH_TIME 106
PETIROC_REG_VTH_TIME 50
PETIROC_REG_VTH_TIME 50
|
In conclusion, pipeline is totally different from qtl-analysis, which takes .hipo file from qtl-histogram. This is the first set of run daq config, which has never run before. I suggest a separate script and directory, because of the same reason we have a separate The daq config is fixed when we take the data, and it doesn't have to be produced every time we update detector timeline. |
|
The I think it's perfectly fine to make Note that |
What's this PR about?
Related to the issue #338 ,
@bobae0124 developed a timeline for the DAQ config, such as ATOF pedestals, when there is
timeline_daqconfig, such as/volatile/clas12/bobaekim/clas12-timeline/outfiles/alert-daqconfig/timeline_daqconfig/How was timeline_daqconfig prepared?
The timeline_daqconfig was from evio2xml output.
The next thing is probably to add this step somewhere in the script, rather than bash command lines.