fix: avert unwanted log level changes from upstream JDBCProvider#1177
Closed
c-dilks wants to merge 1 commit intodevelopmentfrom
Closed
fix: avert unwanted log level changes from upstream JDBCProvider#1177c-dilks wants to merge 1 commit intodevelopmentfrom
JDBCProvider#1177c-dilks wants to merge 1 commit intodevelopmentfrom
Conversation
Calling `JDBCProvider.connect()` destroys the log level of certain loggers, _viz._ `org.freehep.math.minuit`. Instead of attempting to fix upstream, we can save desired log levels and restore them; this is the fix we pretty much do downstream anyway (_e.g._, in `calcode`), where we typically just keep setting the log level we want.
Member
Author
|
Not good enough for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
JDBCProvider.connect()destroys the log level of certain loggers, viz.org.freehep.math.minuit. Instead of attempting to fix upstream, we can save desired log levels and restore them; this is the fix we pretty much do downstream anyway (e.g., incalcode), where we typically just keep setting the log level we want.