Conversation
tagger time calibration [rtj]
assignment of the tree file where beam currents are looked up [rtj]
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/make_PStagstudy_plugin_rtj.log |
Contributor
|
Contributor
Author
|
Hello Alex,
I looked through all of the plugins for the string "new TFile" and I don;t
find anything that looks like a good example. The one exception is
Analysis/photoneff_hists but there I don't find any actual trees being
defined to write into that root file. My worry is that, with the ROOT file
management monolith, by opening this ROOT file for writing, it will grab
other output from other plugins and/or core classes and screw up the ROOT
output structure. How can I be sure that the ROOT file I create and use for
my new TTree will be invisible to all other runtime components?
…-Richard Jones
On Mon, Feb 23, 2026 at 10:15 AM Alexander Austregesilo < ***@***.***> wrote:
*aaust* left a comment (JeffersonLab/halld_recon#1104)
<#1104 (comment)>
- The plugin writes a large tree into the histogram file. It should
create a separate output tree file instead. This can be handled with
DTreeInterface, see other plugins for examples
- The histograms should be placed in a folder with the plugin name.
This makes it easier to identify which plugin fills which histograms in a
production with many plugins.
—
Reply to this email directly, view it on GitHub
<#1104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3YKWEJRWV6YNZPEG5XVIT4NMKQ5AVCNFSM6AAAAACV4YSH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNBVGM2TCNRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
I started working on it, only partially done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.