Conversation
Contributor
Author
|
I have plots for the kinks in a corresponding push in hpstr (i.e. the push for the TrackingProcessor). |
bloodyyugo
reviewed
Feb 5, 2025
tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanPatRecDriver.java
Outdated
Show resolved
Hide resolved
bloodyyugo
reviewed
Feb 5, 2025
tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanPatRecDriver.java
Outdated
Show resolved
Hide resolved
bloodyyugo
reviewed
Feb 5, 2025
tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanPatRecDriver.java
Show resolved
Hide resolved
Contributor
Author
|
I have made corrections so that residuals worked like they did before. |
bloodyyugo
approved these changes
Feb 5, 2025
mgignac
requested changes
Feb 5, 2025
tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanPatRecDriver.java
Outdated
Show resolved
Hide resolved
mgignac
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the only required file change to incorporate the residuals and both types of kinks into our framework. Followed Mat Graham's suggestions.