add tests for kalman tracking; FEE, Moller, and V0 2016#1117
Merged
Conversation
mgignac
approved these changes
Jul 5, 2025
baltzell
approved these changes
Jul 6, 2025
Collaborator
baltzell
left a comment
baltzell
left a comment
There was a problem hiding this comment.
The CI job ran for 26 minutes. That's probably ok, at least for now, but getting long. Parallelizing the tests might be in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess we forgot to put integration tests for Kalman tracking. I've added them for FEE, Moller, and V0s using the 2016 data (following the tests used for GBL).
We might want to add tests for 2021 and/or 2019 and maybe remove the 2015 tests. Currently, with the new additions, the build/test takes about 35 minutes (on an s3df iana machine). This seems like too long to me. It's easy to remove tests just by adding them to the exclude list in the integration-tests/pom.xml.