Skip to content

Adding preliminary hit smearing and hit killing#1142

Merged
mgignac merged 6 commits intomasterfrom
eb-hit-kill-smear
Sep 5, 2025
Merged

Adding preliminary hit smearing and hit killing#1142
mgignac merged 6 commits intomasterfrom
eb-hit-kill-smear

Conversation

@EBerzin
Copy link
Contributor

@EBerzin EBerzin commented Sep 5, 2025

This includes hit efficiency corrections derived from two runs, and the corresponding steering files: PhysicsRun2021MCRecon_KF_WithSpacing_pass3_HitKill_14232.lcsim, PhysicsRun2021MCRecon_KF_WithSpacing_pass3_HitKill_14464.lcsim.

PhysicsRun2021MCRecon_KF_WithSpacing_pass3_HitSmear.lcsim implements the full smearing chain, including position, hit time, and track time smearing. This required adding a new TrackTimeSmearer driver, as well as modifications to the existing smearers to ignore data hits.

@sarahgaiser
Copy link
Collaborator

Here are the changes that need to applied to the recon steering files to get the correct MC track and cluster times.
The EcalTimeCorrection driver is already part of the steering files, but has to be configured a bit differently.

<driver name="EcalTimeCorrection" type="org.hps.recon.ecal.EcalTimeCorrectionDriver">
        <additionalShift>13.3</additionalShift>
</driver>

In RawTrackerHitFitterDriver set tsCorrectionScale to 165 (should be 120 before this change)

<tsCorrectionScale>165</tsCorrectionScale>

This PR should be merged after #1143 which includes all other necessary changes.

@mgignac
Copy link
Collaborator

mgignac commented Sep 5, 2025

For the next MC production, I assume we will want to use:
PhysicsRun2021MCRecon_KF_WithSpacing_pass3_HitSmear.lcsim

The PR looks good to me, but we will need to add the lines Sarah pointed out above to the above steering file before we can proceed. When you get a chance, can you make those changes? Would be great if we could get this running before the weekend, if possible...

Copy link
Collaborator

@sarahgaiser sarahgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@mgignac mgignac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, thanks!

@mgignac mgignac merged commit 73e817f into master Sep 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants