Skip to content

Shifting MC time peaks #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgignac merged 3 commits into from
Sep 5, 2025
Merged

Shifting MC time peaks #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd05924
add settable parameter for time offset of SimTrackerHit
bloodyyugo Sep 3, 2025
6f31465
add time shift for ecal clusters to match MC to data
sarahgaiser Sep 5, 2025
10a4d55
formatting and adjusting another time shift
sarahgaiser Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion digi/src/main/java/org/hps/digi/SvtDigitizationWithPulserDataMergingReadoutDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public class SvtDigitizationWithPulserDataMergingReadoutDriver extends ReadoutDr
private double readoutOffset = 0.0;
private double readoutLatency = 280.0;
private double pileupCutoff = 300.0;
private double simHitTimeOffset=0.0;
private String readout = "TrackerHits";
private double timeOffset = 30.0;
private boolean noPileup = false;
Expand Down Expand Up @@ -194,6 +195,16 @@ public void setDropBadChannels(boolean dropBadChannels) {
public void setReadoutLatency(double readoutLatency) {
this.readoutLatency = readoutLatency;
}


/**
* Set the time offset for the SimTrackerHit
* inside the APV25 window
* @param simHitTimeOffset - The offset to use
*/
public void setSimHitTimeOffset(double simHitTimeOffset) {
this.simHitTimeOffset = simHitTimeOffset;
}

/**
* Sets whether to use manually defined timing conditions, or if
Expand Down Expand Up @@ -473,7 +484,7 @@ private List<StripHit> doSiSimulation() {
// SimTrackerHit.
double time = 0.0;
for(SimTrackerHit hit : simHits) {
time += hit.getTime();
time += hit.getTime()+simHitTimeOffset;
}
time /= simHits.size();
time += ReadoutDataManager.getCurrentTime();
Expand Down Expand Up @@ -628,6 +639,7 @@ protected Collection<TriggeredLCIOData<?>> getOnTriggerData(double triggerTime)
List<SimTrackerHit> truthHits = new ArrayList<SimTrackerHit>();
List<LCRelation> trueHitRelations = new ArrayList<LCRelation>();
// Calculate time of first sample

double firstSample = Math.floor(((triggerTime + 256) - readoutLatency - readoutOffset) / HPSSVTConstants.SAMPLING_INTERVAL)
* HPSSVTConstants.SAMPLING_INTERVAL + readoutOffset;

Expand Down
6 changes: 6 additions & 0 deletions ecal-recon/src/main/java/org/hps/recon/ecal/EcalTimeCorrectionDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public class EcalTimeCorrectionDriver extends Driver {
private boolean mode3 = false;
private boolean useFit = true;
private boolean useTimeWalkCondition = true;
private double additionalShift = 0.0;

private EcalConditions ecalConditions = null;

Expand All @@ -41,6 +42,10 @@ public void setUseFit(boolean useFit) {
this.useFit = useFit;
}

public void setAdditionalShift(double additionalShift) {
this.additionalShift = additionalShift;
}

public void setUseTimeWalkCondition(boolean useTimeWalkCondition) {
this.useTimeWalkCondition = useTimeWalkCondition;
}
Expand Down Expand Up @@ -110,6 +115,7 @@ public void process(EventHeader event) {

// Apply overall time offset
time -= findChannel(hit.getCellID()).getTimeShift().getTimeShift();
time += additionalShift;

newHits.add(CalorimeterHitUtilities.create(energy, time, hit.getCellID()));
}
Expand Down
1 change: 1 addition & 0 deletions ...n/resources/org/hps/steering/readout/PhysicsRun2021TrigSinglesWithPulserDataMerging.lcsim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@
<pulserDataCollectionName>PulserDataSVTRawTrackerHits</pulserDataCollectionName>
<enablePileupCut>false</enablePileupCut>
<useTimingConditions>true</useTimingConditions>
<simHitTimeOffset>-10</simHitTimeOffset>
<addNoise>true</addNoise>
</driver>

Expand Down
60 changes: 31 additions & 29 deletions ...rc/main/resources/org/hps/steering/recon/PhysicsRun2021MCRecon_KF_WithSpacing_pass3.lcsim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
</driver>
<!-- Ecal reconstruction drivers -->
<driver name="EcalRawConverter" type="org.hps.recon.ecal.EcalRawConverter2Driver"/>
<driver name="EcalTimeCorrection" type="org.hps.recon.ecal.EcalTimeCorrectionDriver"/>
<driver name="EcalTimeCorrection" type="org.hps.recon.ecal.EcalTimeCorrectionDriver">
<additionalShift>13.3</additionalShift>
</driver>
<driver name="ReconClusterer" type="org.hps.recon.ecal.cluster.ReconClusterDriver">
<logLevel>WARNING</logLevel>
<outputClusterCollectionName>EcalClusters</outputClusterCollectionName>
Expand All @@ -49,49 +51,49 @@
<isMC>true</isMC>
</driver>
<driver name="HodoRawConverter" type="org.hps.recon.ecal.HodoRawConverterDriver">
<useRunningPedestal>true</useRunningPedestal>
<useRunningPedestal>true</useRunningPedestal>
<inputCollectionName>HodoscopeReadoutHits</inputCollectionName>
<tETAllChannels>8</tETAllChannels>
<logLevel>CONFIG</logLevel>
<tETAllChannels>8</tETAllChannels>
<logLevel>CONFIG</logLevel>
<isMC>true</isMC>
</driver>
<!-- SVT reconstruction drivers -->
<!-- Driver used to associate raw tracker hits to corresponding sensor. -->
<driver name="RawTrackerHitSensorSetup" type="org.lcsim.recon.tracking.digitization.sisim.config.RawTrackerHitSensorSetup">
<readoutCollections>SVTRawTrackerHits</readoutCollections>
<readoutCollections>SVTRawTrackerHits</readoutCollections>
</driver>
<!-- Fit the six raw samples and extract the amplitude and t0. -->
<driver name="RawTrackerHitFitterDriver" type="org.hps.recon.tracking.RawTrackerHitFitterDriver">
<chiSqrThresh>.5</chiSqrThresh>
<doOldDT>1</doOldDT>
<fitAlgorithm>Pileup</fitAlgorithm>
<fitTimeMinimizer>Migrad</fitTimeMinimizer>
<!--use this to correct for trigger time in MC instead of subtractTriggerTime-->
<useTimestamps>true</useTimestamps>
<!--offset to get times centered at 0 after timestamp correction-->
<!-- set to 0 for unspaced; ~112 for spaced -->
<tsCorrectionScale>120</tsCorrectionScale>
<!--correct for the SVT fit time offset...this should be on if <useTimingConditions> is turned on in readout-->
<correctTimeOffset>true</correctTimeOffset>
<!--per sensor shift...set false becasue it's not in readout sim-->
<correctT0Shift>true</correctT0Shift>
<!--use truth time for MC??? typically not used-->
<useTruthTime>false</useTruthTime>
<!--time of flight corrections-->
<subtractTOF>true</subtractTOF>
<!--set this false for MC, true for data-->
<subtractTriggerTime>false</subtractTriggerTime>
<!--per-strip timing correction from database...this should be on i f <useTimingConditions> is turned on in readout -->
<correctChanT0>false</correctChanT0>
<isMC>true</isMC>
<debug>false</debug>
<chiSqrThresh>.5</chiSqrThresh>
<doOldDT>1</doOldDT>
<fitAlgorithm>Pileup</fitAlgorithm>
<fitTimeMinimizer>Migrad</fitTimeMinimizer>
<!--use this to correct for trigger time in MC instead of subtractTriggerTime-->
<useTimestamps>true</useTimestamps>
<!--offset to get times centered at 0 after timestamp correction-->
<!-- set to 0 for unspaced; ~112 for spaced -->
<tsCorrectionScale>165</tsCorrectionScale>
<!--correct for the SVT fit time offset...this should be on if <useTimingConditions> is turned on in readout-->
<correctTimeOffset>true</correctTimeOffset>
<!--per sensor shift...set false becasue it's not in readout sim-->
<correctT0Shift>true</correctT0Shift>
<!--use truth time for MC??? typically not used-->
<useTruthTime>false</useTruthTime>
<!--time of flight corrections-->
<subtractTOF>true</subtractTOF>
<!--set this false for MC, true for data-->
<subtractTriggerTime>false</subtractTriggerTime>
<!--per-strip timing correction from database...this should be on i f <useTimingConditions> is turned on in readout -->
<correctChanT0>false</correctChanT0>
<isMC>true</isMC>
<debug>false</debug>
</driver>
<!--
Use the fitted raw tracker hits and create 1D clusters using a
nearest neighbor algorithm.
-->
<driver name="TrackerHitDriver" type="org.hps.recon.tracking.DataTrackerHitDriver">
<neighborDeltaT>24.0</neighborDeltaT>
<neighborDeltaT>24.0</neighborDeltaT>
<neighborDeltaTSigma>3.0</neighborDeltaTSigma>
<saveMonsterEvents>false</saveMonsterEvents>
<thresholdMonsterEvents>400</thresholdMonsterEvents>
Expand Down
Loading