Add ROCm/HIP compatibility to CuMesh, enabling all 3 extensions#30
Open
ZJLi2013 wants to merge 1 commit intoJeffreyXiang:mainfrom
Open
Add ROCm/HIP compatibility to CuMesh, enabling all 3 extensions#30ZJLi2013 wants to merge 1 commit intoJeffreyXiang:mainfrom
ZJLi2013 wants to merge 1 commit intoJeffreyXiang:mainfrom
Conversation
…lags Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ROCm/HIP compatibility to CuMesh, enabling all 3 extensions (
cumesh._C,cumesh._cubvh,cumesh._cumesh_xatlas) to compile and run on AMD GPUs.Changes (4 files)
src/atlas.cu: Replacecuda::std::plus()with portablecub::Sum()— the CCCLcuda::stdheader is not available on HIPsrc/clean_up.cu: Userocprim::tupleforint3_decomposeron HIP via#ifdef—cuda::std::tupleandthrust::tupleare both unavailable/broken on ROCm 6.4src/dtypes.cuh: Add__host__qualifier to allVec3fandQEMmethods — hipCUB'sDeviceSegmentedReducetemplate instantiation requires host-callable constructorssetup.py: Guard cubvh-specific nvcc flags (--extended-lambda,-U__CUDA_NO_HALF_*) behindIS_HIPcheck — these flags are NVIDIA-specific and cause errors with hipccWhat works
cudaMalloc,cudaMemcpy, etc.) are automatically converted to HIP equivalentsWhat is NOT covered
#ifdefguards or portable replacementsUsage on AMD GPUs
Test Environment
GPU: AMD Instinct MI300X (gfx942)
ROCm: 6.4.3
PyTorch: 2.6.0
Docker: rocm/pytorch:rocm6.4.3_ubuntu24.04_py3.12_pytorch_release_2.6.0