Initial implementation of PEP 661 v2 (sentinels)#4
Open
JelleZijlstra wants to merge 9 commits intomainfrom
Open
Initial implementation of PEP 661 v2 (sentinels)#4JelleZijlstra wants to merge 9 commits intomainfrom
JelleZijlstra wants to merge 9 commits intomainfrom
Conversation
Owner
Author
|
Open questions:
|
Viicos
reviewed
Apr 17, 2026
Gave thoughts on python/peps#4923 (comment). |
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
DanielNoord
reviewed
Apr 18, 2026
DanielNoord
left a comment
There was a problem hiding this comment.
I only looked at the .rst file as my minimal knowledge of C won't help much here. There are a couple of double spaces in some of them, perhaps before merging quickly grep for " " in the diff to remove those :)
Owner
Author
|
Thanks for looking! I think the double spaces are mainly between sentences, that's very common in the docs. It doesn't affect rendering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--4.org.readthedocs.build/