You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @sabonerune, thanks for #99. I tested it, but it seems that older Python doesn't have importlib_metadata out of the box. Therefore, I created this PR and keep pkg_resources instead for the version number. Let me know if that makes sense or if there are any suggestions.
@JeremyCCHsu
I think in most cases using pkg_resources with Python < 3.8 is probably fine.
This is because Setuptools is typically expected to be installed by default on these versions.
Also, since Setuptools has dropped support for these Python versions, there is no need to worry about the API being broken.
It would be a problem if users manually uninstalled Setuptools, but I don't think they would normally do that.
@JeremyCCHsu
I recently learned that setuptools is not installed in the virtual environment created by the package manager uv.
Also, the sdist released on pypi seems to be a different source code than the wheel.
This makes it more likely that errors like ModuleNotFoundError: No module named 'pkg_resources' will occur in environments other than Windows.
@sabonerune@JeremyCCHsu
I found the ModuleNotFoundError: No module named 'pkg_resources' error in Docker image python:3.12 when importing after installing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.