Add SDK version to template for Visual Studio compatibility #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix template not working in Visual Studio
Add SDK version to template for Visual Studio compatibility
Jan 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes Visual Studio's inability to resolve MSBuild SDKs without explicit versions by adding version information to the template's SDK attribute. The solution implements a pack-time substitution mechanism that automatically injects the correct SDK version into generated projects.
Key Changes
- Template project file modified to use
SDKVERSION_PLACEHOLDERthat gets replaced at template instantiation - Template configuration enhanced with a
SdkVersionsymbol parameter with1.0.0as default - Custom MSBuild tasks added for pack-time substitution and source restoration to maintain placeholders in source files
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/JD.Efcpt.Build.Templates/templates/efcptbuild/EfcptProject.csproj | Changed SDK attribute to include version placeholder for template engine replacement |
| src/JD.Efcpt.Build.Templates/templates/efcptbuild/.template.config/template.json | Added SdkVersion symbol configuration with placeholder replacement definition |
| src/JD.Efcpt.Build.Templates/JD.Efcpt.Build.Templates.csproj | Implemented MSBuild targets with custom inline task for pack-time version substitution and restoration |
| src/JD.Efcpt.Build.Tasks/packages.lock.json | Automatic package lock file update with Microsoft.NETFramework.ReferenceAssemblies dependency |
| .gitignore | Added *.bak pattern to exclude backup files created during pack process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…and backup restoration
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JerrettDavis
approved these changes
Jan 4, 2026
Contributor
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 79.94% 87.49% +7.55%
==========================================
Files 50 50
Lines 3350 3350
Branches 455 455
==========================================
+ Hits 2678 2931 +253
+ Misses 487 419 -68
+ Partials 185 0 -185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerrettDavis
approved these changes
Jan 5, 2026
JerrettDavis
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio cannot resolve MSBuild SDKs without explicit versions. The template was generating
<Project Sdk="JD.Efcpt.Sdk">which fails SDK resolution.Changes
<Project Sdk="JD.Efcpt.Sdk/TEMPLATE_SDK_VERSION">with placeholderSdkVersionsymbol withTEMPLATE_SDK_VERSIONas replacement targetPackageVersionduring packImplementation
The substitution target runs before
GenerateNuspec:Generated projects now include:
<Project Sdk="JD.Efcpt.Sdk/0.12.3">(matching template version).Sample projects remain unchanged—they use
global.jsonfor SDK resolution during development.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.