Skip to content

1.19.4 to 1.20.4 minecraft version work & merge 2 world#13

Open
HydrolienF wants to merge 229 commits intoJeshuakrc:mainfrom
HydrolienF:main
Open

1.19.4 to 1.20.4 minecraft version work & merge 2 world#13
HydrolienF wants to merge 229 commits intoJeshuakrc:mainfrom
HydrolienF:main

Conversation

@HydrolienF
Copy link
Copy Markdown
Contributor

Remove version limiting code.
Add performance data in README
Clean code.

@HydrolienF
Copy link
Copy Markdown
Contributor Author

HydrolienF commented Dec 14, 2023

By removing the last use of CraftBukkit class, Underilla can now support multiple versions.
I have test with succes 1.19.4, 1.20.1, 1.20.2, 1.20.4
1.19.2 don't work because of a bukkit class that we use and weren't on 1.19.2 bukkit code. As 1.19.2 is now an old version, I won't search any further to make it work.

@HydrolienF
Copy link
Copy Markdown
Contributor Author

I have also test if doing our own BiomeProvider will fix structure generation in totally unrelated biomes.
This issue is still there if there is cave biome to keep from Minecraft vanilla generator (for the merging strategy relative), it's gone without biome to keep or with any other merging strategy.

@HydrolienF
Copy link
Copy Markdown
Contributor Author

A swamp hut generated in the right biome with Underilla generation
Capture d’écran (1561)

@HydrolienF
Copy link
Copy Markdown
Contributor Author

If you want to do test before merging, I have done a release

@HydrolienF HydrolienF marked this pull request as ready for review December 14, 2023 19:20
@HydrolienF HydrolienF marked this pull request as draft December 15, 2023 08:46
@HydrolienF HydrolienF marked this pull request as ready for review December 15, 2023 21:53
@GoodrichDev
Copy link
Copy Markdown

2024-02-12_21 33 44
It appears this build does not allow for the transfer of biome data from the world_base to the new world. It for some reason continues to use the world seed for biome data

@HydrolienF
Copy link
Copy Markdown
Contributor Author

2024-02-12_21 33 44

It appears this build does not allow for the transfer of biome data from the world_base to the new world. It for some reason continues to use the world seed for biome data

Have you tried 1.3.1 from the link in my last message or the patched version 1.3.2 ?
If you were using 1.3.1 please test with the last release 1.3.2.
Else can you send your config file ? Biome transfer from world base worked for me with a specific configuration. I haven't tested every possible configuration and some might fail to transfer biome even if they should.

raveneau and others added 9 commits February 25, 2024 15:26
This line causes a crash because of a NPE when trying to invoke "readChunk(int, int) on this.worldCavesReader_, which is null.

To resolve this error, fix null check for `this.worldCavesReader_` before invoking readChunk
Fix NPE on worldCavesReader_
@HydrolienF HydrolienF changed the title 1.19.4 to 1.20.4 minecraft version work. 1.19.4 to 1.20.4 minecraft version work & merge 2 world Feb 28, 2024
@HydrolienF
Copy link
Copy Markdown
Contributor Author

HydrolienF commented Feb 28, 2024

Last commits allow to generate a world from 2 existing worlds (one for surface and one for caves).
I thinks that it's the only way to control minecraft population to have ores in caves without having trees on surface.
It also fix the loss of caves biomes when merging / structure missplaced issue.

User should generate a vanilla world at the same coordinates than his worldpainter world.
Then move it to world_caves.
Then generate the world with Underilla (with transfer_world_from_caves_world: true).

For a best result:
To have structures in the write biomes, underground structures should be enable for caves world generation only and surface structures for surface world only.
To have ores but not vanilla tree, populate should be enable for cave world only.
To have a quick render (without issue with sea level and with caves over y=20), SURFACE strategie should be used.
If you wich to have caves visible from surface of the world you might want to generate_noodle_caves: true when merging the 2 world, else to have caves only under the ground disable generate_noodle_caves

A next step could be to integrate a Chunky version inside Underilla and to generate the cave world then merge it with surface world. But it would require 2 config files (1 for cave world generation and 1 for merging the 2 worlds) and a lot of time for only a small improvement.

HydrolienF and others added 30 commits July 23, 2025 21:56
Update the underilla default datapack version
Each Material or EntityType field now have the type of string that are allowed with a link and an example.
Javadoc links are up to date.
This is a pre commit for #26 which will make the config easier to understand.
Thanks to ApexRex65 for sharing the less obvious steps of the step by step tuto.
They was done in separated steps.
It might lag the server, we need to test.
The code and config about the 2 cleaning steps is still there, it will be removed in the futur if it works well.
There is still removeUnstableBlock to do.
Make the cave biome heigh be larger for the 3 cave biome & the same for the 3.
This should fix deed_dark being much more common than the 2 others one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants