First challenge #1
Conversation
Jess2896
force-pushed
the
first-challenge
branch
from
bbfc7a7 to
aefc324
Compare
|
Hello @Jess2896 |
Added a verification process, let me know if its fine like this. |
oscarpolanco
left a comment
oscarpolanco
left a comment
There was a problem hiding this comment.
We can add a few spaces on some of the lines in the code. Here a useful js guideline for js.
Jess2896
force-pushed
the
first-challenge
branch
5 times, most recently
from
ad3edc8 to
022cd34
Compare
script.js
Outdated
| let isMarkHigherBMI = calculateBMI(markMass, markHeight) > calculateBMI(johnMass, johnHeight); | ||
|
|
||
| function calculateBMI(mass, height) { | ||
| return mass / (height * height); |
There was a problem hiding this comment.
On this line, you can add heigth^2 and is the same. What you think; can we update this?
There was a problem hiding this comment.
From what i gather ^ is the XOR bitwise operator and it gives a different result.
There was a problem hiding this comment.
Should put it in words my bad 😅
There is an operator that is for the square. I put the mathematical notation. On js the operator is different
There was a problem hiding this comment.
Ah, I see what you mean. Fixed it.
oscarpolanco
left a comment
oscarpolanco
left a comment
There was a problem hiding this comment.
Good job!! Just a minor comment for fun
script.js
Outdated
| let isMarkHigherBMI = calculateBMI(markMass, markHeight) > calculateBMI(johnMass, johnHeight); | ||
|
|
||
| function calculateBMI(mass, height) { | ||
| return mass / (height * height); |
There was a problem hiding this comment.
Should put it in words my bad 😅
There is an operator that is for the square. I put the mathematical notation. On js the operator is different
Jess2896
force-pushed
the
first-challenge
branch
from
022cd34 to
d2c31b6
Compare
index.html
Outdated
| </body> | ||
| </html> | ||
|
|
||
| <script src='script.js'></script> |
There was a problem hiding this comment.
script tags are included inside the body tag.
script.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| let markMass = 70; | |||
There was a problem hiding this comment.
My bad, realized i should have been using const on the second challenge and fixed the declarations in all the PRs except for this one.
Functionality
Verification steps
Download both files(index.html and script.js) into a folder and then open the index.html file on a browser.
Inspect the website and open the console to see the result obtained.