Skip to content

Conversation

@csiyang
Copy link
Contributor

@csiyang csiyang commented Jan 5, 2026

Feat

  • Removes slider for desktop editor
  • Journey flow takes up full width, content and settings appears in a drawer
  • rewire dispatch actions

To Do

  • Clicking on some of the empty spaces does not close the dialog
  • Check different screen sizes
  • Tidy up code
  • Remove unnecessary code
  • Refactor to simplify parts
  • Have a common styled component for settings drawer
  • Fix mobile
  • still use slider
  • some actions in editor provider has changed, need to add some dispatches to maintain current behaviour
  • Update Tests

To Consider

  • Change journey map origin location
  • share components between mobile and desktop (currently just duplicated all the components in slider)

@csiyang csiyang self-assigned this Jan 5, 2026
@linear
Copy link

linear bot commented Jan 5, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch siyangcao/nes-308-condense-journey-map-and-card-editor-on-one-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Fails
🚫 Please request a reviewer for this PR.
Warnings
⚠️ ❗ Big PR (103124 changes)

(change count - 103124): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against 522a2ca

@nx-cloud
Copy link

nx-cloud bot commented Jan 5, 2026

View your CI Pipeline Execution ↗ for commit 522a2ca

Command Status Duration Result
nx run-many --target=vercel-alias --projects=jo... ✅ Succeeded 2s View ↗
nx run-many --target=upload-sourcemaps --projec... ✅ Succeeded 11s View ↗
nx run-many --target=deploy --projects=journeys... ✅ Succeeded 2m 29s View ↗
nx run-many --target=vercel-alias --projects=watch ✅ Succeeded 2s View ↗
nx run-many --target=vercel-alias --projects=re... ✅ Succeeded 2s View ↗
nx run-many --target=upload-sourcemaps --projec... ✅ Succeeded 5s View ↗
nx run-many --target=vercel-alias --projects=vi... ✅ Succeeded 2s View ↗
nx run-many --target=upload-sourcemaps --projec... ✅ Succeeded 7s View ↗
Additional runs (7) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 01:07:24 UTC

@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 21:37 Inactive
@github-actions github-actions bot had a problem deploying to Preview - journeys-admin January 5, 2026 21:37 Failure
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 21:37 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 21:37 Inactive
@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Jan 5, 2026

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
EditorContext › EditorProvider/should set initial state View Logs
EditorContext › reducer/
SetSelectedBlockAction › should change to content view when block selected
View Logs

Fix in Cursor

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Mon Jan 19 14:03:40 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Mon Jan 19 14:04:21 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
resources ✅ Ready resources preview Mon Jan 19 14:04:19 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Mon Jan 19 14:04:17 NZDT 2026

@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 21:47 Inactive
@github-actions github-actions bot had a problem deploying to Preview - journeys-admin January 5, 2026 21:47 Failure
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 21:47 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 21:47 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 22:03 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Mon Jan 19 14:06:50 NZDT 2026

@csiyang csiyang marked this pull request as draft January 6, 2026 00:42
@github-actions github-actions bot temporarily deployed to Preview - journeys January 19, 2026 01:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 19, 2026 01:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - resources January 19, 2026 01:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 19, 2026 01:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants