Skip to content

chore: health check matcher support to 204 no content #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tataihono wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: health check matcher support to 204 no content #8604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/cms/infrastructure/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ locals {
dns_name = var.ecs_config.alb.dns_name
}
alb_target_group = merge(var.ecs_config.alb_target_group, {
port = local.port
port = local.port
health_check_matcher = "204"
})
auto_scaling = {
max_capacity = 4
Expand Down
1 change: 1 addition & 0 deletions infrastructure/modules/aws/ecs-task/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ resource "aws_alb_target_group" "alb_target_group" {
path = var.service_config.alb_target_group.health_check_path
port = var.service_config.alb_target_group.health_check_port
protocol = var.service_config.alb_target_group.protocol
matcher = var.service_config.alb_target_group.health_check_matcher
}

lifecycle {
Expand Down
1 change: 1 addition & 0 deletions infrastructure/modules/aws/ecs-task/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ variable "service_config" {
health_check_timeout = optional(number, 4)
health_check_healthy_threshold = optional(number, 2)
health_check_unhealthy_threshold = optional(number, 4)
health_check_matcher = optional(string, "200")
})

auto_scaling = object({
Expand Down
Loading