Skip to content

Conversation

@tataihono
Copy link
Contributor

@tataihono tataihono commented Jan 16, 2026

Update default values for FLAG_NPS and FLAG_PROMOTE_EE flags in CMS admin config from true to false.

Changes:

  • FLAG_NPS default: truefalse
  • FLAG_PROMOTE_EE default: truefalse

File: apps/cms/config/admin.ts

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated default configuration settings to disable two administrative features by default, reducing initial system prompts and promotional elements.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

Two feature flags in the CMS admin configuration (FLAG_NPS and FLAG_PROMOTE_EE) had their default boolean values changed from true to false, affecting the default behavior of these optional features.

Changes

Cohort / File(s) Summary
CMS Admin Configuration
apps/cms/config/admin.ts
Updated default values for feature flags: FLAG_NPS and FLAG_PROMOTE_EE now default to false instead of true

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating default values of CMS admin flags to false, which directly matches the changeset modifications to FLAG_NPS and FLAG_PROMOTE_EE.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/change-cms-flags-default


📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 98bd101 and fd2a2fa.

📒 Files selected for processing (1)
  • apps/cms/config/admin.ts
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/base.mdc)

**/*.{ts,tsx,js,jsx}: Use early returns whenever possible to make the code more readable.
Use descriptive variable and function/const names.
Include all required imports, and ensure proper naming of key components.

Files:

  • apps/cms/config/admin.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/base.mdc)

Define a type if possible.

Files:

  • apps/cms/config/admin.ts
apps/**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/apps.mdc)

apps/**/*.{js,jsx,ts,tsx}: Always use MUI over HTML elements; avoid using CSS or tags.
Use descriptive variable and function/const names. Also, event functions should be named with a “handle” prefix, like “handleClick” for onClick and “handleKeyDown” for onKeyDown.
Implement accessibility features on elements. For example, a tag should have a tabindex=“0”, aria-label, on:click, and on:keydown, and similar attributes.

Files:

  • apps/cms/config/admin.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: affected (22)
  • GitHub Check: lint (22)
  • GitHub Check: build (22)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/cms/config/admin.ts (1)

17-18: LGTM — default flags updated as intended.
This aligns with the stated goal of disabling NPS and Promote EE by default.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Fails
🚫 Please ensure your PR title matches commitlint convention.
🚫 Please assign someone to merge this PR.
🚫 Please request a reviewer for this PR.

(pr title - Change CMS admin flags default values to false):

subject may not be empty

type may not be empty

Generated by 🚫 dangerJS against fd2a2fa

@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2026

View your CI Pipeline Execution ↗ for commit fd2a2fa

Command Status Duration Result
nx affected --target=subgraph-check --base=98bd... ✅ Succeeded <1s View ↗
nx affected --target=extract-translations --bas... ✅ Succeeded <1s View ↗
nx affected --target=lint --base=98bd101550bd06... ✅ Succeeded 6s View ↗
nx affected --target=type-check --base=98bd1015... ✅ Succeeded <1s View ↗
nx run-many --target=codegen --all --parallel=3 ✅ Succeeded 2s View ↗
nx run-many --target=prisma-generate --all --pa... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-16 07:16:38 UTC

@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2026

View your CI Pipeline Execution ↗ for commit fd2a2fa

Command Status Duration Result
nx affected --target=subgraph-check --base=98bd... ✅ Succeeded <1s View ↗
nx affected --target=extract-translations --bas... ✅ Succeeded <1s View ↗
nx affected --target=lint --base=98bd101550bd06... ✅ Succeeded 6s View ↗
nx affected --target=type-check --base=98bd1015... ✅ Succeeded <1s View ↗
nx run-many --target=codegen --all --parallel=3 ✅ Succeeded 2s View ↗
nx run-many --target=prisma-generate --all --pa... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-16 07:16:07 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants