fix: multiselect undo and redo to update cache and render correctly

[jaycnz]

Summary by CodeRabbit

• Bug Fixes

  • Improved undo/redo functionality for multiselect block creation with proper cleanup and removal of all associated elements when undoing operations.
  • Enhanced state restoration when redoing multiselect block operations.

• Tests

  • Strengthened test validation for cache state management during block operations.
  • Added comprehensive checks for undo/redo workflows and state consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[linear]

NES-1032 Unable to undo Multiselect block right after creation.

[coderabbitai]

Walkthrough

The PR updates the NewMultiselectButton component and its tests to change GraphQL mock data from flat objects to array-based structures, enhance Apollo cache initialization, and extend undo/redo operations with comprehensive cache cleanup on deletion and block restoration on redo.

Changes

Cohort / File(s)	Summary
Test Specifications apps/journeys-admin/src/components/Editor/Slider/Settings/CanvasDetails/AddBlock/NewMultiselectButton/NewMultiselectButton.spec.tsx	GraphQL mock responses restructured from flat objects to single-entry arrays; Apollo cache initialization switched to empty blocks arrays; cache validation expectations updated to reflect array-based block references; MockedProvider now accepts pre-populated cache; additional async checks added for create/restore action verification; undo/redo flows assert new array-based cache state structure
Component Implementation apps/journeys-admin/src/components/Editor/Slider/Settings/CanvasDetails/AddBlock/NewMultiselectButton/NewMultiselectButton.tsx	Added Reference type import from @apollo/client; undo path now tracks all created blocks in createdBlocks array and performs cache cleanup (removal and eviction) with garbage collection; optimistic response simplified to null values; update handler introduced for delete mutation cache cleanup; redo path enhanced with update handler to restore block references to Journey blocks list; optimistic response extended to include startIcon and endIcon fields

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Component as NewMultiselectButton<br/>Component
    participant Apollo as Apollo Cache
    participant Mutation as GraphQL Mutation

    User->>Component: Create multiselect
    Component->>Mutation: Create mutation (multiselect, options,<br/>button, icons)
    Mutation->>Apollo: Write optimistic response
    Mutation-->>Component: Return created blocks
    Apollo->>Apollo: Add block references to<br/>Journey blocks array

    User->>Component: Undo (delete created blocks)
    Component->>Mutation: Delete mutation
    Mutation->>Apollo: Set fields to null<br/>(optimisticResponse)
    Mutation-->>Component: Return mutation data
    Apollo->>Apollo: Iterate createdBlocks
    Apollo->>Apollo: Remove refs from<br/>Journey blocks list
    Apollo->>Apollo: Evict each block<br/>cache entry
    Apollo->>Apollo: Run garbage<br/>collection

    User->>Component: Redo (restore blocks)
    Component->>Mutation: Create mutation (restore)
    Mutation-->>Component: Return restored blocks
    Apollo->>Apollo: For each block,<br/>append ref to<br/>Journey blocks list
    Apollo->>Apollo: Update Journey<br/>query cache

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• feat: add submit button on card form template #6286: Modifies add/delete/restore mutation handling with createdBlocks tracking and performs cache cleanup/restore operations via update handlers.
• feat: multiselect block frontend #7723: Updates the same NewMultiselectButton component and adjusts Apollo cache/mutation handling for multiselect block operations.

Suggested reviewers

• edmonday
• tanflem

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: fixing multiselect undo/redo functionality by updating Apollo cache handling and ensuring proper rendering.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jaychen/nes-1032-unable-to-undo-multiselect-block-right-after-creation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 050c941

Command	Status	Duration	Result
nx run journeys-admin-e2e:e2e	✅ Succeeded	32s	View ↗
nx run-many --target=vercel-alias --projects=jo...	✅ Succeeded	2s	View ↗
nx run-many --target=upload-sourcemaps --projec...	✅ Succeeded	11s	View ↗
nx run-many --target=deploy --projects=journeys...	✅ Succeeded	2m 33s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-01-19 02:07:52 UTC

[github-actions]

The latest updates on your projects.

Name	Status	Preview	Updated (UTC)
journeys-admin	✅ Ready	journeys-admin preview	Mon Jan 19 15:04:49 NZDT 2026

[edmonday]

Good idea to provide some type safety when using this mutation.

Suggested change

	const [multiselectWithButtonRestore] = useMutation<MultiselectWithButtonRestore, MultiselectWithButtonRestoreVariables>(