Skip to content

fix: reset template customisation scroll on screen change #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csiyang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: reset template customisation scroll on screen change #8613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5014879
reset scroll
csiyang Jan 19, 2026
6dbbce7
remove debug border
csiyang Jan 19, 2026
05fa09c
refactor comment
csiyang Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion apps/journeys-admin/src/components/TemplateCustomization/MultiStepForm/MultiStepForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Container from '@mui/material/Container'
import Stack from '@mui/material/Stack'
import NextLink from 'next/link'
import { useTranslation } from 'next-i18next'
import { ReactElement, useMemo, useState } from 'react'
import { ReactElement, useEffect, useMemo, useRef, useState } from 'react'

import { useJourney } from '@core/journeys/ui/JourneyProvider'
import Edit3 from '@core/shared/ui/icons/Edit3'
Expand Down Expand Up @@ -75,6 +75,27 @@ export function MultiStepForm(): ReactElement {

const [activeScreen, setActiveScreen] =
useState<CustomizationScreen>('language')
const containerRef = useRef<HTMLDivElement>(null)

// Because of how react renders the screens, the scroll position is not reset when the screen changes.
// This is a workaround to reset the scroll position when the screen changes.
useEffect(() => {
requestAnimationFrame(() => {
const scrollContainer = document.querySelector<HTMLElement>(
'[data-testid="MainPanelBody"]'
)
if (scrollContainer != null) {
scrollContainer.scrollTop = 0
}

const appHeader = document.querySelector<HTMLElement>('#app-header')
if (appHeader != null) {
requestAnimationFrame(() => {
appHeader.scrollIntoView({ block: 'start', behavior: 'instant' })
})
}
})
}, [activeScreen])

async function handleNext(): Promise<void> {
if (activeScreen !== screens[screens.length - 1]) {
Expand All @@ -92,6 +113,7 @@ export function MultiStepForm(): ReactElement {

return (
<Container
ref={containerRef}
maxWidth="sm"
sx={{
width: '100%',
Expand Down Expand Up @@ -134,6 +156,7 @@ export function MultiStepForm(): ReactElement {
)}

<Box
key={activeScreen}
sx={{
alignSelf: 'center',
width: '100%',
Expand Down