refactor: videos admin workspace #8632
Conversation
- Adjusted .gitignore to correctly include node_modules. - Updated nx.json to specify pnpm as the package manager. - Removed deprecated NestJS dependencies from package.json. - Updated pnpm-lock.yaml to reflect changes in dependencies. - Added new packages to pnpm-workspace.yaml. - Refactored TypeScript paths in tsconfig.base.json for better module resolution. - Updated project.json paths in api-journeys for TranslationModule. - Removed unused NestJS common library and its related files. - Refactored imports in various files to align with the new structure.
- Updated various dependencies in `package.json` for `@nestjs` packages and others to their latest versions. - Removed the unused webpack IgnorePlugin configuration from `webpack.config.js` as it was no longer necessary.
- Removed unused dependencies: `@mui/x-charts`, `@mui/x-tree-view`, `next-firebase-auth-edge`, and `react-loading-hook` from `package.json`. - Updated `pnpm-lock.yaml` to reflect these changes and ensure consistency across the project.
WalkthroughThis change restructures a monorepo by removing shared dependencies from the root package.json, creating new sub-package manifests for api-journeys and videos-admin with their specific dependencies, and updating configuration to use pnpm as the package manager. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f969266
☁️ Nx Cloud last updated this comment at |
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apis/api-journeys/package.json`:
- Around line 10-13: Dependencies show mixed NestJS versions and a known vuln in
11.0.12; update all `@nestjs/`* packages referenced (e.g., "@nestjs/common",
"@nestjs/core", "@nestjs/platform-express", "@nestjs/testing", and
"@nestjs/graphql" if applicable) to 11.0.16 or later in package.json (both
dependencies and devDependencies), reinstall/lock (npm install or yarn) to
update the lockfile, and run the test/build to ensure compatibility.
In `@apps/videos-admin/package.json`:
- Line 9: The package.json dependency "next-firebase-auth-edge" is pinned to a
canary pre-release (^1.7.0-canary.2); update it to the stable release by
replacing the version string for the "next-firebase-auth-edge" entry with
"^1.11.1" so the project uses the stable v1.11.1 instead of canary pre-releases.
After changing the version, run your package manager install (npm/yarn/pnpm) to
update lockfiles and verify builds/tests pass.
🧹 Nitpick comments (3)
apps/videos-admin/package.json (1)
1-5: Consider consistent package naming convention.The package name
videos-adminis unscoped, whileapis/api-journeys/package.jsonuses the scoped name@core/api-journeys. Consider using a consistent naming convention across workspace packages (e.g.,@core/videos-admin) for better organization and clarity.apis/api-journeys/package.json (2)
16-16: Inconsistent version pinning strategy.
file-typeuses^20.4.1while all other dependencies use exact versions. Consider using a consistent versioning strategy across dependencies for reproducible builds.
19-19:adal-nodeis deprecated; consider migrating to@azure/msal-node.The
adal-nodelibrary (Azure Active Directory Authentication Library) is deprecated by Microsoft and no longer supported. Microsoft ended support and development on June 30, 2023, and the npm package explicitly recommends migrating to@azure/msal-node(Microsoft Authentication Library for Node.js). Continuing to useadal-nodecarries security and support risk.
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
follow up after api-journeys
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.