feat(cms): add vite config and compression middleware #8643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Vite configuration with optimized chunk splitting for CMS admin - Add compression middleware to Strapi config - Add hls.js version override in package.json - Replace vite.config.example.ts with vite.config.ts Refs: AI-8
Contributor
WalkthroughThis PR introduces compression middleware for the CMS, upgrades the Docker base image from Alpine to Debian with updated system dependencies and restructured build stages, replaces Docker Actions with useblacksmith alternatives across multiple CI/CD workflows, adds concurrency controls to prevent workflow conflicts, configures hls.js dependency override, and enables npm workspace package injection. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run journeys-admin-e2e:e2e |
❌ Failed | 2m 1s | View ↗ |
nx run watch-e2e:e2e |
✅ Succeeded | 27s | View ↗ |
nx run videos-admin-e2e:e2e |
✅ Succeeded | 6s | View ↗ |
nx run journeys-e2e:e2e |
✅ Succeeded | 27s | View ↗ |
nx run watch-modern-e2e:e2e |
✅ Succeeded | 5s | View ↗ |
nx run resources-e2e:e2e |
✅ Succeeded | 15s | View ↗ |
nx run short-links-e2e:e2e |
✅ Succeeded | 3s | View ↗ |
nx run player-e2e:e2e |
✅ Succeeded | 4s | View ↗ |
Additional runs (28) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-27 20:09:32 UTC
github-actions
bot
requested a deployment
to
Preview - journeys-admin
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
- Eliminated the manual chunk splitting logic for vendor libraries in the Vite configuration to simplify the build process.
- Eliminated concurrency configurations from production and staging deployment workflows to simplify the setup.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/cms/Dockerfile`:
- Around line 31-36: The build fails because pnpm deploy --prod excludes
devDependencies, but strapi build (triggered by RUN ["npm", "run", "build"])
needs TypeScript to parse vite.config.ts. In the Dockerfile section containing
pnpm deploy --prod --filter cms ./apps/cms/deploy and WORKDIR
/app/apps/cms/deploy, remove the --prod flag from the pnpm deploy command so
TypeScript is included, or move typescript from devDependencies to dependencies
in the cms package to ensure it’s present during the Docker build.
Comment on lines
+31
to
+36
| RUN --mount=type=cache,id=pnpm-store,target=/root/.local/share/pnpm/store \ | ||
| pnpm deploy --prod --filter cms ./apps/cms/deploy | ||
|
|
||
| RUN chown -R node:node /opt/apps/cms | ||
| USER node | ||
| WORKDIR /app/apps/cms/deploy | ||
|
|
||
| RUN ["npm", "run", "build"] |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check package.json in apps/cms for dependency placement
echo "=== Finding package.json files ==="
find apps/cms -maxdepth 2 -name "package.json" -type f
echo ""
echo "=== Content of apps/cms/package.json ==="
if [ -f "apps/cms/package.json" ]; then
cat apps/cms/package.json | jq '.' | head -100
fiRepository: JesusFilm/core
Length of output: 1145
🏁 Script executed:
#!/bin/bash
# Check if vite.config.ts exists and examine full Dockerfile
echo "=== Searching for vite.config.ts ==="
find apps/cms -name "vite.config.ts" -o -name "vite.config.js"
echo ""
echo "=== Full Dockerfile content ==="
cat apps/cms/Dockerfile
echo ""
echo "=== Checking if strapi build requires vite ==="
grep -r "vite" apps/cms --include="*.json" --include="*.ts" --include="*.js" || echo "No vite references found"Repository: JesusFilm/core
Length of output: 1365
Move typescript to dependencies or remove --prod flag from pnpm deploy.
The pnpm deploy --prod command excludes devDependencies, but strapi build needs TypeScript to parse vite.config.ts. Since TypeScript is currently in devDependencies only, the build will fail in the Docker container. Either move typescript to dependencies or use pnpm deploy --filter cms ./apps/cms/deploy without the --prod flag.
🤖 Prompt for AI Agents
In `@apps/cms/Dockerfile` around lines 31 - 36, The build fails because pnpm
deploy --prod excludes devDependencies, but strapi build (triggered by RUN
["npm", "run", "build"]) needs TypeScript to parse vite.config.ts. In the
Dockerfile section containing pnpm deploy --prod --filter cms ./apps/cms/deploy
and WORKDIR /app/apps/cms/deploy, remove the --prod flag from the pnpm deploy
command so TypeScript is included, or move typescript from devDependencies to
dependencies in the cms package to ensure it’s present during the Docker build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Files Changed
apps/cms/config/middlewares.ts- Added compression middlewareapps/cms/src/admin/vite.config.ts- New Vite config with manual chunk splittingapps/cms/src/admin/vite.config.example.ts- Removed (replaced by vite.config.ts)package.json- Added hls.js overridepnpm-lock.yaml- Updated dependenciesRefs: AI-8
Summary by CodeRabbit
New Features
Refactor
Chores
Style
✏️ Tip: You can customize this high-level summary in your review settings.