Refactor ui-backhandler to use compose-less NavigationEvent API
#2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuanyingchou
reviewed
Oct 3, 2025
|
|
||
| var progressChannel: Channel<BackEventCompat>? by remember(onBack) { | ||
| mutableStateOf(null) | ||
| val handler = remember(enabled, onBack) { |
There was a problem hiding this comment.
Should maybe move enabled out so that we don't create a new handler when the value changes (and then remove the old one, add the new one, and thus change handlers' order):
val handler = remember(onBack) {
ProgressBackEventHandler(enabled, onBack, coroutineScope)
}
handler.isBackEnabled = enabled
| "No NavigationEventDispatcher was provided via LocalCompatNavigationEventDispatcherOwner" | ||
| ) | ||
| val dispatcher = owner.navigationEventDispatcher | ||
| val handler = remember(enabled, onBack) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required to handle a native klibs compilation problem: https://youtrack.jetbrains.com/issue/KT-60874
Fixes CMP-9008 Fix backward compatibility of
uimodule klibs due to removingui-backhandlerdependencyRelease Notes
N/A