[DBA-126] Fix dbt source count showing 0 connections#65
Closed
[DBA-126] Fix dbt source count showing 0 connections#65
Conversation
Include dbt sources (agent.sources.dbts) in the source count across CLI ask command, welcome page, sidebar, and context settings. Previously only dbs and dfs were counted, causing "Connected to 0 data source(s)" when only dbt sources were configured. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI reported "Connected to 0 data source(s)" when only dbt sources were configured, because the source count only summed
dbs+dfs, omittingdbts. This fix addslen(agent.sources.dbts)to the count in all 4 affected locations (CLI, welcome page, sidebar, context settings).Changes
Fix source counting to include dbt
Added
dbtsto source count and display logic.Files
src/databao_cli/commands/ask.pysrc/databao_cli/ui/pages/welcome.pysrc/databao_cli/ui/components/sidebar.pysrc/databao_cli/ui/pages/context_settings.pyAdd regression tests
Two new tests verifying dbt-only and mixed source counting.
Files
tests/test_ask.pyTest Plan
uv run pytest tests/test_ask.py -v— 3 tests passuv run ruff check+mypy— cleandatabao ask, verify count > 0🤖 Generated with Claude Code